Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Open Source #8

Merged
merged 13 commits into from Sep 2, 2021
Merged

Open Source #8

merged 13 commits into from Sep 2, 2021

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented May 13, 2021

This PR does the following:

  1. Adds/rearranges documentation to make it easy for someone to hit the github page and know what to do to get started.
  2. Adds a license - Apache 2.0
  3. Scrubs the documentation of obvious things we wouldn't want to mention. I leave in some variable names because I think they are not leaking anything.

I'll squash merge this PR.

@skrawcz skrawcz linked an issue May 13, 2021 that may be closed by this pull request
8 tasks
See https://github.com/cla-assistant/github-action

Instead of manually having to manage this, we can have a
bot do it for us.

This will mean that people who contribute will agree and then
this will store this in a file in this repository.

Note, if we don't want Stitch Fix people to be hit by this,
we just need to add them to the allow list.
It was decided that this would be easier for us to open source and manage
with an Apache 2.0 license.
@skrawcz skrawcz marked this pull request as ready for review July 28, 2021 03:51
@danfisher-sf
Copy link
Contributor

This is so exciting!

@danfisher-sf
Copy link
Contributor

i think you've scrubbed well and I'm not anxious about anything that's still in the markdowns, though, it may be worth adding a comment to the readme somewhere that states all of the code examples are just for illustration and do not reflect anything we are doing internally. just to cover ourselves.

because to someone not from Stitch Fix it wouldn't be clear what is meant.
Due to conversation with legal, they think it's best to go with this license.
They were all running together on one line.
README.md Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirements to open source hamilton
2 participants