fix: fix error encountered with Azure Storage. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the handling of a 304 response where the server is not responding with the correct headers (e.g. Azure Storage). A 304 response for a resource should have the same headers as a 200 response for the same resource; when those headers are missing, we error saying that the server said it was unmodified, but the cache says the body needs updating. Instead of returning an error, we now serve up the stale cached body as the server says it was unmodified. However, as we don't update the stored policy object, a future request for the same resource will always preform revalidation until the server responds with a 200 or a correctly implemented 304. This commit includes an update to the dependencies and a reformatting of `Cargo.toml` based on `cargo sort`.
peterhuene
requested review from
a-frantz,
acfoltzer,
adthrasher and
claymcleod
Member
|
Do you have an example of a 200/304 response pair that exhibits this behavior? There is only a limited subset of headers that are required to match what their 200 counterparts would contain (link) |
Contributor
Author
|
For example, Azure Blob Storage returns an There's a 7 year old issue on their feedback page about this... |
acfoltzer
approved these changes
Aug 12, 2025
Member
acfoltzer
left a comment
acfoltzer
left a comment
There was a problem hiding this comment.
Approving for now given the need for these responses to be delivered successfully. I suspect that down the road we'll want to add some logic that treats a 304 as a successful revalidation with a best-effort use of the lifetime-related headers on the original object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of a 304 response where the server is not responding with the correct headers (e.g. Azure Storage).
A 304 response for a resource should have the same headers as a 200 response for the same resource; when those headers are missing, we error saying that the server said it was unmodified, but the cache says the body needs updating.
Instead of returning an error, we now serve up the stale cached body as the server says it was unmodified. However, as we don't update the stored policy object, a future request for the same resource will always preform revalidation until the server responds with a 200 or a correctly implemented 304.
This PR includes an update to the dependencies and a reformatting of
Cargo.tomlbased oncargo sort.