Skip to content

Conversation

@sauhardh
Copy link
Contributor

@sauhardh sauhardh commented Mar 22, 2025

This PR implements the smol runtime replacing the async-std because it's depricated

Some changes:

  • Replaced async-std with smol and included alias name spawn_blocking for smol::unblock.
  • replacing closure with function itself io::Error::other(e).

Test Pass:

  • [☑️] cargo test
  • [☑️] cargo test -p http-cache-stream-reqwest
  • [☑️] cargo clippy --all
  • [☑️] cargo +nightly fmt --check
  • [☑️] cargo doc

Related Issue:
#8

Copy link
Contributor

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sauhardh.

Thanks very much for implementing this!

Looks great, just two tiny nits in the formatting of Cargo.toml entries, but otherwise ready to go!

@peterhuene
Copy link
Contributor

One thing that is missing is an update to .github/workflows/CI.yml to pass the new feature flag instead of async-std.

@sauhardh
Copy link
Contributor Author

@peterhuene Thankyou for guidance, I have again updated the code based on your review. Please review and let me know if something need to be changed.

@peterhuene peterhuene self-requested a review March 27, 2025 14:49
Copy link
Contributor

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sauhardh. Thanks very much for the contribution!

I'll merge once CI goes green.

@peterhuene peterhuene merged commit 39a7948 into stjude-rust-labs:main Mar 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants