Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON retrieval #1

Closed
stklcode opened this issue Sep 27, 2016 · 1 comment
Closed

JSON retrieval #1

stklcode opened this issue Sep 27, 2016 · 1 comment
Assignees
Milestone

Comments

@stklcode
Copy link
Owner

@stklcode stklcode commented Sep 27, 2016

The Connector interface should provide a method for retrieval of secrets mapped as JSON object. Simple code, as Jackson is already present

Suggestion for a generic API :

public <T> T readSecretJson(final String key, final Class<T> type);
@stklcode stklcode added this to the 0.3 milestone Sep 27, 2016
@stklcode stklcode self-assigned this Sep 27, 2016
stklcode added a commit that referenced this issue Sep 27, 2016
@stklcode
Copy link
Owner Author

@stklcode stklcode commented Oct 6, 2016

I decided not to expand the Interface, but to add a second getter to the SecretResponse model to parse the response into a JSON serializable object of choice:

public <T> T getValue(Class<T> type);
@stklcode stklcode closed this Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant