Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sealing methods should throw Exception instead of catching it #12

Closed
stklcode opened this issue Aug 18, 2017 · 1 comment
Closed

Sealing methods should throw Exception instead of catching it #12

stklcode opened this issue Aug 18, 2017 · 1 comment
Assignees
Milestone

Comments

@stklcode
Copy link
Owner

@stklcode stklcode commented Aug 18, 2017

Currently seal() returns just a boolean value, if the sealing succeeded. The method should be refactored to throw an Exception instead.

Same for unseal() and sealStatus() which return null instead of a SealResponse.

Both methods print stack traces, which will also be removed.

@stklcode
Copy link
Owner Author

@stklcode stklcode commented Aug 28, 2017

Merged into develop branch => done.

@stklcode stklcode closed this Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant