Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not print stack traces #13

Closed
stklcode opened this issue Aug 18, 2017 · 1 comment
Closed

Do not print stack traces #13

stklcode opened this issue Aug 18, 2017 · 1 comment
Assignees
@stklcode
Labels
enhancement has patch
Milestone
0.7

Comments

@stklcode
Copy link
Owner

stklcode commented Aug 18, 2017 •
edited

4 methods of the HTTPVaultConnector class and 4 methods in Response models currently call printStackTrace() which is not only bad practice, but also unnecessary. Assumingly an artifact of early development stages.

3 of them will be handled as part of #12, the rest is quite trivial to circumvent.
@stklcode stklcode added this to the 0.7 milestone Aug 18, 2017
@stklcode stklcode self-assigned this Aug 18, 2017
stklcode added a commit that referenced this issue Aug 18, 2017
@stklcode
Do not print stacktrace on PUT request (#13)
c8a2e07
stklcode added a commit that referenced this issue Aug 18, 2017
@stklcode
Do not print stacktrace in response models (#13)
238ac8b
@stklcode
Copy link
Owner Author

With merge of #12 no more StackTraces are printed. Every method now either throws its own exception or silently ignores it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stklcode stklcode

Labels
enhancement has patch
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
1 participant
@stklcode