Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Factory to Builder #18

Closed
stklcode opened this Issue Apr 10, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@stklcode
Copy link
Owner

stklcode commented Apr 10, 2018

The VaultConnectorFactory is more of a builder than an actual factory from a pattern point of view.

In v0.8 the factory class will be deprecated and superseded by a VaultConnectorBuilder with identical API. For now the old class delegates to the new builder.

(this issue is just opened for documentation/discussion purposes, as the implementation is already done)

@stklcode stklcode added this to the 0.8 milestone Apr 10, 2018

@stklcode stklcode self-assigned this Apr 10, 2018

@stklcode stklcode changed the title MIgrate Factory to Builder Migrate Factory to Builder Apr 10, 2018

@stklcode stklcode closed this Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.