Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CIDR subnet binding to new parameter #24

Closed
stklcode opened this Issue Nov 19, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@stklcode
Copy link
Owner

stklcode commented Nov 19, 2018

When working with AppRole backends the bound CIDR subnets are currently stored in the bound_cidr_list parameter. However Vault returns the following warning:

WARNING! The following warnings were returned from Vault:

  * The "bound_cidr_list" parameter is deprecated and will be removed in favor
  of "secret_id_bound_cidrs".

We should migrate to the new parameter.

@stklcode stklcode added this to the 0.8 milestone Nov 19, 2018

@stklcode stklcode self-assigned this Nov 19, 2018

stklcode added a commit that referenced this issue Nov 19, 2018

Support secret_id_bound_cidrs replacing bound_cidr_list for AppRole (#24
)

The latter parameter is deprecated in Vault. The connector now supports
both while the former one is deprecated and will be removed when it is
removed from Vault.

@stklcode stklcode closed this Nov 20, 2018

@stklcode

This comment has been minimized.

Copy link
Owner Author

stklcode commented Nov 20, 2018

Introduces new method AppRoleBuilder#withSecretIdBoundCidrs(List) and deprecated the preexisting AppRoleBuilder#withBoundCidrList(List).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.