Removing virtuals #118
Closed
Removing virtuals #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually building vtables to avoid UB casting through void* with non-standard-layout classes (because inheritance with virtual members). concept and models should now be standard-layout.
Fixing static vtables for C++14 (no inline statics until 17) Removed const from vtable* in concept to avoid possible laundering issue.
Codecov Report
@@ Coverage Diff @@
## develop #118 +/- ##
===========================================
+ Coverage 94.86% 94.88% +0.02%
===========================================
Files 36 36
Lines 4806 4830 +24
Branches 234 234
===========================================
+ Hits 4559 4583 +24
Misses 98 98
Partials 149 149
Continue to review full report at Codecov.
|
FelixPetriconi
approved these changes
Jan 12, 2018
|
Was merged with PR #130. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually building vtables to avoid UB casting through void* with non-standard-layout classes (because inheritance with virtual members). concept and models should now be standard-layout.