Merged
Conversation
Fixed unnecessary copies of copyable result types when futures are used as rvalues. Propagating exceptions for move-only types are now scheduled on the executor (I'm not sure why they were not scheduled before). Added `copy()` algorithm to utility.hpp to explicitly copy objects.
stlab/utility.hpp
Outdated
| /// Returns a copy of the argument. Used to pass an lvalue to function taking an rvalue or to | ||
| /// copy a type with an `explicit` copy-constructor. | ||
| template <typename T> | ||
| T copy(const T& a) { |
Member
There was a problem hiding this comment.
Previously you gave an implementation of copy to be:
template <typename T>
constexpr std::decay_t<T> copy(T&& value) noexcept(
noexcept(std::decay_t<T>{static_cast<T&&>(value)})) {
static_assert(!std::is_same<std::decay_t<T>, T>::value, "explicit copy of rvalue.");
return std::decay_t<T>{static_cast<T&&>(value)};
}What's changed between now and then that's resulted in the greatly simplified variant?
Member
Author
There was a problem hiding this comment.
Moving to use the above - nothing changed other than my memory of writing the above...
fosterbrereton
approved these changes
Nov 8, 2022
Member
fosterbrereton
left a comment
fosterbrereton
left a comment
There was a problem hiding this comment.
I had one question about your copy implementation. Other than that I don't see anything wrong with this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed unnecessary copies of copyable result types when futures are used as rvalues. Propagating exceptions for move-only types are now scheduled on the executor (I'm not sure why they were not scheduled before). Added
copy()algorithm to utility.hpp to explicitly copy objects. Added docs and tests.