Updates value error messages to be consistent. #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2022 12:48
Provide both the type and value that failed conversion. Tries not to "toString" large value types like Arrays or Maps. For those types it will just output the type and not a value.
|
Thanks @johnjaylward starting 3 day comment window. |
gcf-merge-on-green bot
pushed a commit
to googleapis/java-spanner
that referenced
this pull request
Sep 29, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.json:json](https://togithub.com/douglascrockford/JSON-java) | `20220320` -> `20220924` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>douglascrockford/JSON-java</summary> ### [`v20220924`](https://togithub.com/stleary/JSON-java/releases/tag/20220924) [Compare Source](https://togithub.com/douglascrockford/JSON-java/compare/20220320...20220924) | Pull Request | Description | |---------------|--------------| | [#​688](https://togithub.com/douglascrockford/JSON-java/issues/688) | Update copyright to Public Domain | | [#​687](https://togithub.com/douglascrockford/JSON-java/issues/687) | Fix a typo | | [#​685](https://togithub.com/douglascrockford/JSON-java/issues/685) | JSONObject map type unit tests | | [#​684](https://togithub.com/douglascrockford/JSON-java/issues/684) | Remove v7 build from pipeline | | [#​682](https://togithub.com/douglascrockford/JSON-java/issues/682) | JSONString similarity | | [#​675](https://togithub.com/douglascrockford/JSON-java/issues/675) | [stleary/JSON-java#675 | </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-spanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDEuMyIsInVwZGF0ZWRJblZlciI6IjMyLjIwMS4zIn0=-->
](https://renovatebot.com){kind=link}
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #649
What problem does this code solve?
Updates value error messages to be consistent. Some errors would output value information, but others not.
Provide both the type and value that failed conversion. Tries not to
"toString" large value types like Arrays or Maps. For those types it
will just output the type and not a value.
Risks
Low
Changes to the API?
No
Will this require a new release?
Yes
Should the documentation be updated?
No
Does it break the unit tests?
Yes. Some tests that verify error messages have been updated.
Was any code refactored in this commit?
Private methods were removed that allowed generation of the error messages with no value information.
Review status
APPROVED