Skip to content

Splitted the patch for merging RTCSEL in an individual file#18

Merged
adamgreig merged 1 commit into
stm32-rs:masterfrom
gbip:patch-f446
May 29, 2018
Merged

Splitted the patch for merging RTCSEL in an individual file#18
adamgreig merged 1 commit into
stm32-rs:masterfrom
gbip:patch-f446

Conversation

@gbip

@gbip gbip commented May 24, 2018

Copy link
Copy Markdown
Contributor

See Missing patch for stm32f446 (#17).
I think this is correct but I can't get to generate the rs files : make svd2rust -j8; ls stm32f4/src outputs :

.rw-rw-r--  1,4k 24 mai   14:11 lib.rs
.rw-rw-r--     0  24 mai   14:17 stm32f401.rs
.rw-rw-r--     0  24 mai   14:17 stm32f405.rs
.rw-rw-r--     0  24 mai   14:17 stm32f407.rs
.rw-rw-r--     0  24 mai   14:17 stm32f410.rs
.rw-rw-r--     0  24 mai   14:17 stm32f411.rs
.rw-rw-r--     0  24 mai   14:17 stm32f412.rs
.rw-rw-r--     0  24 mai   14:17 stm32f413.rs
.rw-rw-r--     0  24 mai   14:17 stm32f427.rs
.rw-rw-r--     0  24 mai   14:17 stm32f429.rs
.rw-rw-r--     0  24 mai   14:17 stm32f446.rs
.rw-rw-r--     0  24 mai   14:17 stm32f469.rs

@gbip gbip mentioned this pull request May 24, 2018
@gbip

gbip commented May 29, 2018

Copy link
Copy Markdown
Contributor Author

Can you take a look at this please 😄
I have a few projects downstream that need this PR to be merged 😄

@adamgreig

Copy link
Copy Markdown
Member

Ah yep sorry, I missed this the first time. I'll check it out this evening.

@adamgreig

Copy link
Copy Markdown
Member

This seems fine and generates the files OK on my end, are there any errors when you run Make?

@adamgreig adamgreig merged commit 057c7da into stm32-rs:master May 29, 2018
@gbip

gbip commented Jun 14, 2018

Copy link
Copy Markdown
Contributor Author

Can you update the stm32f4 crate on crates.io, please ?
I can't find a way to use git to access the latest modifications...

@adamgreig

adamgreig commented Jun 14, 2018

Copy link
Copy Markdown
Member

Yep, I was about to do that now!

(edit): you can't use the git repository as a dependency because it doesn't contain the generated rust files (they're too big). Annoying. #5 would probably help with this but changes a lot of other things.

@adamgreig

Copy link
Copy Markdown
Member

(also please note that the new version being released will be using the latest svd2rust 0.13.1 which is a breaking change for downstream crates)

@adamgreig

Copy link
Copy Markdown
Member

Done, 0.2.0 is now on https://crates.io/crates/stm32f4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants