Repository navigation
Correct stm32g4 comparator register offsets. - #335
Merged
Merged
Conversation
I've quoted the offsets so they're written in hex in the generated SVD. This matches section 23.6.2 in STM reference manual RM440.
adamgreig
approved these changes
Feb 12, 2020
adamgreig
left a comment
adamgreig
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for the patch!
bors r+
bors Bot
added a commit
that referenced
this pull request
Feb 12, 2020
335: Correct stm32g4 comparator register offsets. r=adamgreig a=lynaghk Thanks for all your work on this project, it's really cool to be able to write Rust on microcontrollers! In my YAML patch I quoted the offsets so they're written out as hex in the generated SVD to match section 23.6.2 in STM reference manual RM440:  I've verified that the patch works to correct COMP6 on an stm32g474 nucleo board. Co-authored-by: Kevin J. Lynagh <kevin@keminglabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for all your work on this project, it's really cool to be able to write Rust on microcontrollers!
In my YAML patch I quoted the offsets so they're written out as hex in the generated SVD to match section 23.6.2 in STM reference manual RM440:
I've verified that the patch works to correct COMP6 on an stm32g474 nucleo board.