Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DMA support for USART #12

Merged
merged 3 commits into from Jun 17, 2019

Conversation

@hannobraun
Copy link
Member

commented Jun 14, 2019

I've started implemented DMA support for USART. I'm submitting this as a draft, as it's not done yet.

Currently, only writing to USART via DMA is supported. Next week, I plan to implement reading from USART and add support for DMA interrupts.

@mvertescher If you have any thoughts so far, I'd love to hear them. I realize this is a complex API, but I believe the complexity is required to prevent incorrect use of the DMA peripheral through the HAL API.

@hannobraun hannobraun marked this pull request as ready for review Jun 17, 2019

@hannobraun

This comment has been minimized.

Copy link
Member Author

commented Jun 17, 2019

I've changed my mind. I'm submitting this pull request as-is. The extensions I'm working on are a bit more involved than I thought, and there's really no point in overloading one pull request with all of them, when this is already useful as-is.

@mvertescher

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

Spent a bit reviewing this PR and overall it seems consistent with stm32f7 family and other existing DMA implementations. As a result, I don't have any major concerns. Also, I didn't find the API too complex, however we may find ways to simplify it in the future after some use.

The extensions I'm working on are a bit more involved than I thought, and there's really no point in overloading one pull request with all of them, when this is already useful as-is.

Sounds like a good plan to me. This PR certainly provides value already.

I definitely like where this implementation is heading. Thanks for your work on this @hannobraun!

@mvertescher mvertescher merged commit 7d6483f into stm32-rs:master Jun 17, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@hannobraun hannobraun deleted the braun-embedded:usart-dma branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.