Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DMA support to SPI API #16

Merged
merged 5 commits into from Jul 9, 2019

Conversation

@hannobraun
Copy link
Member

commented Jul 9, 2019

No description provided.

hannobraun added some commits Jul 5, 2019

Make DMA API more flexible, less safe
To support typical SPI use cases, it must be possible to have two
ongoing DMA transfers that both read from/write to the same buffer. This
is not possible with the current DMA abstractions.

This commit solves that problem, by relaxing the requirements on the
creation of a new `Transfer`. As a consequence, the safe constructors of
`Transfer` have been removed, and only the unsafe variant is available
now. This is unfortunate, but I believe it is necessary.

Please note that the burden of calling the unsafe constructor is put on
the peripheral APIs. This doesn't change anything for the end user, who
will still use the same (safe) APIs to start DMA transfers.
@mvertescher
Copy link
Member

left a comment

lgtm!

@mvertescher mvertescher merged commit 99863b5 into stm32-rs:master Jul 9, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@hannobraun hannobraun deleted the braun-embedded:spi-dma branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.