Add DMA support to SPI API#16
Merged
Merged
Conversation
To support typical SPI use cases, it must be possible to have two ongoing DMA transfers that both read from/write to the same buffer. This is not possible with the current DMA abstractions. This commit solves that problem, by relaxing the requirements on the creation of a new `Transfer`. As a consequence, the safe constructors of `Transfer` have been removed, and only the unsafe variant is available now. This is unfortunate, but I believe it is necessary. Please note that the burden of calling the unsafe constructor is put on the peripheral APIs. This doesn't change anything for the end user, who will still use the same (safe) APIs to start DMA transfers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.