Add support for 16-bit SPI transfers via DMA#18
Merged
Conversation
There was a configuration error in the SPI module that caused 16-bit mode to not work correctly. The 16-bit words were basically treated as two bytes. This was indicated by the fact that I had to convert the word in the example to big endian to get the right result. When I first discovered that this conversion was necessary, I was suprised, but eventually convinced myself that this was normal. Well, it isn't, and the way it works now makes a lot more sense.
mvertescher
approved these changes
Jul 14, 2019
mvertescher
left a comment
mvertescher
left a comment
Member
There was a problem hiding this comment.
Solid change, thanks for the example!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull contains the following changes: