Split AES API, make non-blocking #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the discussion in #11[1], specifically this comment by the maintainer: #11 (comment) [1] #11
Revert the AES module to my original formatting, as rustfmt is no longer mandatory.
I'm currently working on adding DMA support to the AES API. To do that effectively, I need different structs for AES input and output, but those can only be available while the AES peripheral is active. This commit prepares to add those input/output structs, by using a different struct to represent an active AES peripheral, `CtrStream`. The input/output structs can then be added to that.
This change is already beneficial on its own, as the new API is non-blocking. In addition, it paves the way for adding DMA support to the AES API. The old blocking API is kept for convenience. It is now implemented as a wrapper on top of the new API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the AES API into two parts, one for reading, one for writing. This has two advantages:
I've kept the previous
processmethod as a convenience wrapper around the newread/writemethods.I'm currently working on adding DMA support to the AES API. This is an in-progress snapshot, but it's already an improvements in itself, so I figured I submit it here, as smaller changes are easier to review and merge.
I have additional commits here, to test on the Tlera Corp Gnat: https://github.com/braun-embedded/stm32l0xx-hal/compare/aes-dma...braun-embedded:aes-gnat
cc @lthiery