Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ADC work on STM32L0x2, some fixes #18

Merged
merged 10 commits into from Jul 19, 2019
Merged

Make ADC work on STM32L0x2, some fixes #18

merged 10 commits into from Jul 19, 2019

Conversation

hannobraun
Copy link
Contributor

@hannobraun hannobraun commented Jul 19, 2019

As the title says. Details in the commits.

This pull request shares its first commit with #13. To keep the history as clean as possible, it might make sense to merge one of the first, then wait until I have rebased the other one.

cc @lthiery

hannobraun added 8 commits Jul 17, 2019
As per the discussion in #11[1], specifically this comment by the
maintainer:
#11 (comment)

[1] #11
The variant names did not match the values described in the reference
manual, both for STM32L0x1 and STM32L0x2.
There were two problems with the channel selection:
1. Due to the use of `modify`, channels were only ever enabled, never
   disabled again.
2. The code was a bit fragile in regards to defining new channels. I'm
   defining new channels in a follow-up commit, and I forgot to update
   this code at first.
Those can be used to correctly define features that are only available
in specific packages.

These are all the packages available for STM32L072 and STM32L082.
@hannobraun
Copy link
Contributor Author

hannobraun commented Jul 19, 2019

Something's wrong with my updates to the Travis configuration (build matrix doesn't work as I want it to). I'm looking into it.

@hannobraun
Copy link
Contributor Author

hannobraun commented Jul 19, 2019

Okay, I got it working. I've commented most of the feature combinations that I added, as Travis runs only a handful of them at a time, which makes it take way too long. There's still a full build running as I'm writing this, but so far it's looking good.

@arkorobotics arkorobotics merged commit 12aed40 into stm32-rs:master Jul 19, 2019
@hannobraun hannobraun deleted the adc branch Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants