Make ADC work on STM32L0x2, some fixes#18
Merged
Conversation
As per the discussion in #11[1], specifically this comment by the maintainer: #11 (comment) [1] #11
The variant names did not match the values described in the reference manual, both for STM32L0x1 and STM32L0x2.
There were two problems with the channel selection: 1. Due to the use of `modify`, channels were only ever enabled, never disabled again. 2. The code was a bit fragile in regards to defining new channels. I'm defining new channels in a follow-up commit, and I forgot to update this code at first.
Those can be used to correctly define features that are only available in specific packages. These are all the packages available for STM32L072 and STM32L082.
Contributor
Author
|
Something's wrong with my updates to the Travis configuration (build matrix doesn't work as I want it to). I'm looking into it. |
Contributor
Author
|
Okay, I got it working. I've commented most of the feature combinations that I added, as Travis runs only a handful of them at a time, which makes it take way too long. There's still a full build running as I'm writing this, but so far it's looking good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says. Details in the commits.
This pull request shares its first commit with #13. To keep the history as clean as possible, it might make sense to merge one of the first, then wait until I have rebased the other one.
cc @lthiery