Make DMA-based AES API more ergonomic #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arkorobotics Yes. #16 is fully ready. This PR (#19) still includes the commit from #16, but I'm marking it "Ready for review", as the one shared commit shouldn't be too much of a hindrance in reviewing. |
|
Sounds good, how would you like to resolve these merge conflicts? |
They shouldn't be there :-) I'll take a look later today! |
I'm working on some changes that require `Transfer::new` to be opened up to the rest of the crate, so I think it makes sense to not require weird PAC types when calling it.
The problem with these constructors is that they're not flexible enough. In general, peripheral APIs might want to present DMA transfers to the user in a different way than they work in hardware. For example, the AES peripheral supports only transfers of 32-bit words, but might want to present an API that works with byte slices (I'm currently working on this). Another example would be SPI, which might want to hide two simultaneous DMA transfers (for read and write) behind a single transfer struct. This commit doesn't make these use cases possible yet, as some modifications to the unsafe constructor are still required. But it paves the way, by exposing that constructor to the peripheral APIs. Please note that none of this exposes any unsafety to the users. They will still use the same (safe) peripheral APIs to access DMA.
The new trait, `Buffer`, provides everything the DMA code needs from the buffer, without requiring implementers to be able to return a slice. This makes the trait more flexible, as it can be implemented for a larger variety of types, without requiring any complex transmuting.
The type parameter names were wrong, as they were in a different order than was used everywhere else in the code. Please note that this didn't cause any incorrect behavior, as just the names were wrong and nothing else.
This should be more natural than operating with `u32` words.
|
I don't know what GitHub's problem is. This rebased flawlessly, no conflicts in sight. Anyways, all should be well now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the AES API to work with
u8buffers, instead ofu32buffers, which should make it easier to use in most scenarios.I've also snuck in a few commits that fix and improve some other things related to AES and DMA. It didn't seem worth it to create a separate pull request for those, especially since I've already got a bit a bit of a traffic jam going :-)
This pull request is based on #16. I recommend reviewing/merging that one first.
cc @lthiery