Add support for wakeup via RTC wakeup timer #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values used for almost, but not quite, correct. I thought that I'd set the two prescaler factors to 64 and 512 by writing those values, but what I actually did was set them to 65 and 513, as per reference manual. Those new values set them to 128 and 256, which are the values recommended in a piece of documentation that I've previously missed, which should set the clock frequency used by the calendar to a clean 1 Hz.
As far as I can tell, what was there before didn't match the documentation. The new asserts match the supported bits on both STM32L0x1 and STM32L0x2.
This is just the minimal change required to add support for the RTC wakeup timer to RTC's `wait_for_irq` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this pull requests adds support for waking up from low-power modes using the RTC wakeup timer. In addition it adds some fixes of and improvements upon my previous RTC PR.
It also makes some changes to the EXTI API that are required to support the RTC wakeup timer. The new capabilities are basically duct-taped on top of the old ones, which leads to some weird issues (like the
listen'sportargument being ignored when it doesn't make sense).This is far from the ideal approach, and I believe there's a possible EXTI API that is much more type-safe and has more natural support for non-GPIO interrupts. However, I don't have the time to figure that out right now.
I plan to go back and take a look at an EXTI redesign after I've completed some more urgent task. Probably late September or October.
cc @lthiery