Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve USB module #59

Merged
merged 3 commits into from Nov 21, 2019
Merged

Improve USB module #59

merged 3 commits into from Nov 21, 2019

Conversation

hannobraun
Copy link
Contributor

@hannobraun hannobraun commented Nov 21, 2019

This improves the usb module, bringing it more in line with other modules and making the API less error-prone.

hannobraun added 3 commits Nov 21, 2019
This follows the standards established in other modules.
This follows the standards established by other peripheral APIs, and
prevents the user from messing with the USB peripheral or the pins after
initialization.
This prevents mistakes (USB won't work without HSI48) and restores the
behavior of the old API, before the recent changes.
@arkorobotics
Copy link
Member

arkorobotics commented Nov 21, 2019

Great! Given all the recent additions, I think it's time to release the current repo (after merging this) as v0.5.0. Thoughts? Do we want to close out all open issues before doing so?

@arkorobotics arkorobotics merged commit 1330097 into stm32-rs:master Nov 21, 2019
@hannobraun
Copy link
Contributor Author

hannobraun commented Nov 26, 2019

Great! Given all the recent additions, I think it's time to release the current repo (after merging this) as v0.5.0. Thoughts? Do we want to close out all open issues before doing so?

Sorry for the late reply! A new release sounds good to me.

Regarding the open issues, I definitely plan to close #42 before the year is over, but I wouldn't block the release on that. I currently have no plans to work on #52.

I plan to add a Flash API very soon (pull request incoming this week, if nothing goes wrong, but who knows). Don't know, if you want to wait for that.

@hannobraun hannobraun deleted the usb branch Nov 26, 2019
@Disasm
Copy link
Member

Disasm commented Nov 26, 2019

Is HSI48 absolutely required for USB to work on L0?

@hannobraun
Copy link
Contributor Author

hannobraun commented Nov 26, 2019

Is HSI48 absolutely required for USB to work on L0?

I think there are other clocks that can be used in its place, although I don't recall the details right now. HSI48 is the only one currently supported in the HAL API.

@arkorobotics
Copy link
Member

arkorobotics commented Nov 27, 2019

@hannobraun No worries. Let's wait for the Flash API. That sounds like a great addition before the next rev (no pressure 😛).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants