Repository navigation
Clean up serial module - #161
Merged
Merged
Conversation
Collaborator
Author
|
Looks like there are some problems with the CI build (it builds for me locally). I'll take a look tomorrow. |
Collaborator
Author
|
Okay, that was a simple fix. I did some rebasing before pushing the branch. The error probably slipped in when I was doing that, and I forgot to run the build again. In any case, it works now. |
Replaces the combinatorial explosion of the previous pin macro with a more targeted approach. The new macro implements one trait for each kind of pin. The `Pins` trait is then implemented using blanked implementations using the pin-traits.
Now pins can be accessed using, for example, `crate::gpio::PA1` instead of `crate::gpio::gpioa::PA1`. The names are already unambigous, and not only can this make all imports slighly more convenient, it can also help cut down a lot on use statements required for macro-generated code.
Collaborator
Author
|
Rebased on master, incorporating #150 into the configuration. @MabezDev, @korken89, @MathiasKoch: It would be great if handling this pull request could be a priority over other USART-related pull requests. I believe this is a clear-cut improvement, but keeping it up to date with further changes is going to be a very error-prone process. |
korken89
approved these changes
Nov 2, 2020
korken89
left a comment
korken89
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, nice cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly cleans up how supported pins are defined, but also includes commits that clean up the
usestatements (which required a small change togpio). All details in the commits.