New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Rework physical memory protection (PMP) [NAPOT -> TOR] #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comment/description and default value (now 4 bytes)
use a single PMP entry instead
replaced PMP's NAPOT mode by TOR mode (easier to use, much more flexible); CSR read access logic optimization/clean-up
stnolting
added
the
risc-v compliance
Modification to comply with official RISC-V specs.
label
Feb 26, 2022
* rework PMP * replace PMP NAPOT mode by TOR mode * remove BUSKEEPER's NULL pointer check (access to address zero)
stnolting
changed the title
⚠️ Rework physical memory protection (PMP)
⚠️ Rework physical memory protection (PMP) [NAPOT -> TOR]
Feb 26, 2022
limiting the maximum amount of PMP regions to 16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a complete rework of the CPU's Physical Memory Protection (PMP).
The optional physical memory protection allows to define access rights (read/write/execute) for custom memory regions. By default, all PMP rules only apply to user-mode but can also be enforced for machine-mode.
The pre-PR PMP only provided "NAPOT" mode, where protected memory regions had to be a naturally aligned power of two. This PR removes the NAPOT mode and replaces it by the "TOR" mode (top of region), which is a base and bound scheme that is easier to handle (and easier to understand).
The NEORV32 PMP (and the TOR mode) is compatible to the RISC-V privileged architecture specifications section 3.7.
✨ This PR adds a new demo program to illustrate PMP usage (
sw/example/demo_pmp
).