Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Stardew Valley 1.3.33 and SMAPI 3.0, fix crossplatform compatibility #1

Closed
wants to merge 13 commits into from

Conversation

Projects
None yet
1 participant
@Pathoschild
Copy link

commented Nov 23, 2018

This pull request...

  • Adds compatibility with Stardew Valley 1.3.33 and SMAPI 3.0 (still compatible with SMAPI 2.10).
  • Reworks Harmony patching for crossplatform compatibility.*
  • Migrates to the new package reference format.
  • Updates the mod build config package and migrates to the new Harmony package.
  • Simplifies the project file using the mod build config features (e.g. i18n and manifest.json files are copied automatically).
  • Bumps the manifest.json versions for release.
  • Fixes various errors reported by users.

* (SMAPI automatically handles code changes between Linux/Mac and Windows, but it can't do that for type references in attributes. Using Harmony's API instead means the mod will work seamlessly across Linux/Mac/Windows without needing separate builds.)

Let me know if you want me to make any changes!

Pathoschild added some commits Nov 23, 2018

rework Harmony patching for crossplatform compatibility
SMAPI automatically handles code changes between Linux/Mac and Windows, but it can't do that for type references in attributes. Using Harmony's API instead means the mod will work seamlessly across Linux/Mac/Windows without needing separate builds.

@Pathoschild Pathoschild changed the title Update for Stardew Valley 1.3.32 and SMAPI 2.8 Update for Stardew Valley 1.3.32 and SMAPI 2.8, fix crossplatform compatibility Nov 27, 2018

Pathoschild added some commits Jan 9, 2019

@Pathoschild Pathoschild changed the title Update for Stardew Valley 1.3.32 and SMAPI 2.8, fix crossplatform compatibility Update for Stardew Valley 1.3.33 and SMAPI 3.0, fix crossplatform compatibility Jan 9, 2019

Pathoschild added some commits Jan 10, 2019

@Pathoschild

This comment has been minimized.

Copy link
Author

commented May 25, 2019

Superceded by PR #3.

@Pathoschild Pathoschild deleted the Pathoschild:update-code branch May 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.