Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix LowList Poster image selection logic. #64

Merged
merged 5 commits into from Apr 11, 2012

Conversation

Projects
None yet
2 participants
Collaborator

jingai commented Apr 11, 2012

Special listings that contain more than one show or season (such as RecentlyAddedEpisodes and All Seasons) don't set Container.SeasonThumb for obvious reasons. They should instead set ListItem.Property(SeasonThumb) but XBMC appears to currently only set that for DialogVideoInfo.

The new logic attempts to use ListItem.Property(SeasonThumb) if it's in either of those views, and fall back to Container.TvshowThumb (if in All Seasons) or to tvshow.jpg (if in RecentlyAddedEpisodes).

This should make it magically start working as intended once XBMC fills in the SeasonThumb listitem property, but for now use reasonable defaults.

This takes care of Issue #6, partially at least.

jingai added some commits Apr 11, 2012

@jingai jingai Re-tweak viewtype attributes.
Was defaulting to List, but would rather it prefer Files.  List is simply
too sparse to be the default.
fddad05
@jingai jingai Code cleanup in DialogVideoInfo. f76d755
@jingai jingai Fix LowList Poster image selection logic.
Special listings that contain more than one show or season (such as
RecentlyAddedEpisodes and All Seasons) don't set Container.SeasonThumb
for obvious reasons.  They should instead set ListItem.Property(SeasonThumb)
but XBMC appears to currently only set that for DialogVideoInfo.

The new logic attempts to use ListItem.Property(SeasonThumb) if it's in
either of those views, and fall back to Container.TvshowThumb (if in
All Seasons) or to tvshow.jpg (if in RecentlyAddedEpisodes).

This should make it magically start working as intended once XBMC fills
in the SeasonThumb listitem property, but for now use reasonable defaults.
35deb55
@jingai jingai Fix warble while scrolling plot in DialogVideoInfo ee26dc1
@jingai jingai DialogVideoInfo: Show file path for Episodes too. 316c3c6

@stoli stoli added a commit that referenced this pull request Apr 11, 2012

@stoli stoli Merge pull request #64 from jingai/lowlistposter
Fix LowList Poster image selection logic.
c42e45e

@stoli stoli merged commit c42e45e into stoli:master Apr 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment