Not working on ST3 #6

Closed
ajitam opened this Issue Jan 6, 2014 · 14 comments

Comments

Projects
None yet
8 participants
@ajitam

ajitam commented Jan 6, 2014

When I try to run it in ST3 I get:

Traceback (most recent call last):
  File "/Applications/Sublime Text.app/Contents/MacOS/sublime_plugin.py", line 549, in run_
    return self.run(edit)
  File "/Users/john/Library/Application Support/Sublime Text 3/Packages/CleanCSS/CleanCSS.py", line 44, in run
    self.formatRegion(cssRule)
  File "/Users/john/Library/Application Support/Sublime Text 3/Packages/CleanCSS/CleanCSS.py", line 77, in formatRegion
    result = self.createPartitionedRules(result, results[1])
  File "/Users/john/Library/Application Support/Sublime Text 3/Packages/CleanCSS/CleanCSS.py", line 165, in createPartitionedRules
    result = [filterAndSortRules(lines,rl) for rl in ruleLists]
TypeError: 'NoneType' object is not iterable

I noticed that spaces (rule alignment) are added

OSX 10.7.5
Sublime Text 3 Build 3059

@alejandro

This comment has been minimized.

Show comment
Hide comment
@alejandro

alejandro Mar 10, 2014

Is ST3 support planned?

Is ST3 support planned?

@cirocosta

This comment has been minimized.

Show comment
Hide comment
@cirocosta

cirocosta Mar 10, 2014

👍 for ST3 support

👍 for ST3 support

@jamiewilson

This comment has been minimized.

Show comment
Hide comment
@jamiewilson

jamiewilson Mar 11, 2014

Please add support for ST3. This looks so awesome! Thanks for making it.

Please add support for ST3. This looks so awesome! Thanks for making it.

@stolksdorf

This comment has been minimized.

Show comment
Hide comment
@stolksdorf

stolksdorf Mar 12, 2014

Owner

Hey guys, just finished adding Less support, currently working on getting it working on ST3. Hoping it should be done by next week. Thanks for being patient!

Owner

stolksdorf commented Mar 12, 2014

Hey guys, just finished adding Less support, currently working on getting it working on ST3. Hoping it should be done by next week. Thanks for being patient!

@cirocosta

This comment has been minimized.

Show comment
Hide comment

That's awesome @stolksdorf

@stolksdorf

This comment has been minimized.

Show comment
Hide comment
@stolksdorf

stolksdorf Mar 21, 2014

Owner

Hey champs, I just pushed support for Less. I haven't had time to work on ST3 support too much, but I think I've narrowed down the issue to how I'm loading in the user settings (in ST3 this is now an async call instead of sync). If someone could take a look at my new stuff and give me some pointers I would really appreciate it.

I'm still adding features and tweaking how Less is processed, so if you have any suggestions or bugs, throw them my way!

Owner

stolksdorf commented Mar 21, 2014

Hey champs, I just pushed support for Less. I haven't had time to work on ST3 support too much, but I think I've narrowed down the issue to how I'm loading in the user settings (in ST3 this is now an async call instead of sync). If someone could take a look at my new stuff and give me some pointers I would really appreciate it.

I'm still adding features and tweaking how Less is processed, so if you have any suggestions or bugs, throw them my way!

@binarykitchen

This comment has been minimized.

Show comment
Hide comment
@binarykitchen

binarykitchen Feb 18, 2015

Any news on ST3 support??

Any news on ST3 support??

@znk

This comment has been minimized.

Show comment
Hide comment
@znk

znk Feb 24, 2015

I second @binarykitchen, @stolksdorf your plugin is damn good. If you need help, you can write down what's left to do. Hope to see ST3 supported soon !

znk commented Feb 24, 2015

I second @binarykitchen, @stolksdorf your plugin is damn good. If you need help, you can write down what's left to do. Hope to see ST3 supported soon !

@stolksdorf

This comment has been minimized.

Show comment
Hide comment
@stolksdorf

stolksdorf Mar 2, 2015

Owner

Since I don't use ST3 nor a python developer, I haven't prioritized this. I've attempted to update it a few times, but it never went anywhere. If you guys are familiar with Python 3, I encourage you to take a look at updating it. Everything should be mostly migrate-able, but I was having issues with reading in the config file in Python 3. I hope that helps!

Owner

stolksdorf commented Mar 2, 2015

Since I don't use ST3 nor a python developer, I haven't prioritized this. I've attempted to update it a few times, but it never went anywhere. If you guys are familiar with Python 3, I encourage you to take a look at updating it. Everything should be mostly migrate-able, but I was having issues with reading in the config file in Python 3. I hope that helps!

@iRJ

This comment has been minimized.

Show comment
Hide comment
@iRJ

iRJ Jul 13, 2015

Still using ST2 because of this plugin! Would really appreciate if @stolksdorf or someone else could continue with it for ST3! Havent found a plugin that does exactly what this one does!

iRJ commented Jul 13, 2015

Still using ST2 because of this plugin! Would really appreciate if @stolksdorf or someone else could continue with it for ST3! Havent found a plugin that does exactly what this one does!

@stolksdorf

This comment has been minimized.

Show comment
Hide comment
@stolksdorf

stolksdorf Jul 14, 2015

Owner

Thanks for the reminder @iRJ. I finally did the switch to ST3 last week, and your comment was the push I needed to update this. I have a pull request waiting on Package Control right now, but if you want to jump the gun you can grab a zip of it here. Let me know if it works for you!

Owner

stolksdorf commented Jul 14, 2015

Thanks for the reminder @iRJ. I finally did the switch to ST3 last week, and your comment was the push I needed to update this. I have a pull request waiting on Package Control right now, but if you want to jump the gun you can grab a zip of it here. Let me know if it works for you!

@iRJ

This comment has been minimized.

Show comment
Hide comment
@iRJ

iRJ Jul 14, 2015

Thanks so much @stolksdorf !!! Would love to test it right now, but not sure how to add the plugin manually into ST3... else I will just wait for it to be available within Package control. Thanks again so much!

iRJ commented Jul 14, 2015

Thanks so much @stolksdorf !!! Would love to test it right now, but not sure how to add the plugin manually into ST3... else I will just wait for it to be available within Package control. Thanks again so much!

@iRJ

This comment has been minimized.

Show comment
Hide comment
@iRJ

iRJ Jul 20, 2015

Was able to install it now via Package Control for ST3, but does not seem to work. When I execute the clean_css command it doesn't do anything really.

iRJ commented Jul 20, 2015

Was able to install it now via Package Control for ST3, but does not seem to work. When I execute the clean_css command it doesn't do anything really.

@stolksdorf

This comment has been minimized.

Show comment
Hide comment
@stolksdorf

stolksdorf Jul 20, 2015

Owner

Package Control didn't properly pick up my release. Fixed it now! For me I needed to restart my Sublime after installation for it to work.

I also added the ability to change the type of character CleanCSS indents with. So you crazy cats using 3 space indents won't be left out now.

Let me know if you have any other issues, sorry this took so long!

Owner

stolksdorf commented Jul 20, 2015

Package Control didn't properly pick up my release. Fixed it now! For me I needed to restart my Sublime after installation for it to work.

I also added the ability to change the type of character CleanCSS indents with. So you crazy cats using 3 space indents won't be left out now.

Let me know if you have any other issues, sorry this took so long!

@stolksdorf stolksdorf closed this Jul 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment