Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InstallPlan variable to SubmarinerConfig #270

Closed
manosnoam opened this issue Feb 7, 2022 · 4 comments · Fixed by #282
Closed

Add InstallPlan variable to SubmarinerConfig #270

manosnoam opened this issue Feb 7, 2022 · 4 comments · Fixed by #282
Assignees
@skitt
Projects
Submariner ACM integration

Comments

@manosnoam
Copy link

In order to pin Submariner operator version installed, to prevent auto update with its default Subscription:

submariner-addon/pkg/hub/submarineragent/manifests/operator/submariner-operator-subscription.yaml

Line 10 in e9fb859

installPlanApproval: Automatic

Please add installPlanApproval variable to SubmarinerConfig, so it can be set to "Manual".
@skitt skitt added this to To do (for ACM 2.5) in Submariner ACM integration via automation Feb 7, 2022
@MaxBab
Copy link

MaxBab commented Feb 13, 2022

According to the submarinerconfig object, installPlan parameter is not supported within the SubmarinerConfig.

@skitt
Copy link
Member

skitt commented Feb 14, 2022

According to the submarinerconfig object, installPlan parameter is not supported within the SubmarinerConfig.

I think that’s the point of this feature request — to add some way of configuring installPlanApproval in SubmarinerConfig.

@skitt skitt self-assigned this Feb 14, 2022
@skitt skitt moved this from To do (for ACM 2.5) to In progress (for ACM 2.5) in Submariner ACM integration Feb 14, 2022
skitt added a commit to skitt/submariner-addon that referenced this issue Feb 14, 2022
@skitt
Add InstallPlan configuration to SubmarinerConfig
338bf9d 
This adds an InstallPlanApproval entry to the SubscriptionConfig
object in SubmarinerConfig, allowing the subscription's
InstallPlanApproval entry to be configured.

Fixes: stolostron#270
Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt skitt mentioned this issue Feb 14, 2022
Merged
skitt added a commit to skitt/submariner-addon that referenced this issue Feb 14, 2022
@skitt
Add InstallPlan configuration to SubmarinerConfig
967d4ff 
This adds an InstallPlanApproval entry to the SubscriptionConfig
object in SubmarinerConfig, allowing the subscription's
InstallPlanApproval entry to be configured.

Fixes: stolostron#270
Signed-off-by: Stephen Kitt <skitt@redhat.com>
@nyechiel nyechiel moved this from In progress (for ACM 2.5) to Review in progress (for ACM 2.5) in Submariner ACM integration Feb 14, 2022
@nyechiel
Copy link
Member

@skitt IIUC, this would also need to be backported to release-2.4 once merged?

@sridhargaddam @tpantelis can you review please? This is currently blocking QE downstream.

skitt added a commit to skitt/submariner-addon that referenced this issue Feb 15, 2022
@skitt
Add InstallPlan configuration to SubmarinerConfig
f31d87f 
This adds an InstallPlanApproval entry to the SubscriptionConfig
object in SubmarinerConfig, allowing the subscription's
InstallPlanApproval entry to be configured.

Fixes: stolostron#270
Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt
Copy link
Member

skitt commented Feb 15, 2022

@skitt IIUC, this would also need to be backported to release-2.4 once merged?

Yes, I’ve queued a cherry-pick.

Submariner ACM integration automation moved this from Review in progress (for ACM 2.5) to Done Feb 15, 2022
openshift-merge-robot pushed a commit that referenced this issue Feb 15, 2022
@skitt @openshift-merge-robot
Add InstallPlan configuration to SubmarinerConfig
4f1fafb 
This adds an InstallPlanApproval entry to the SubscriptionConfig
object in SubmarinerConfig, allowing the subscription's
InstallPlanApproval entry to be configured.

Fixes: #270
Signed-off-by: Stephen Kitt <skitt@redhat.com>
skitt added a commit to skitt/submariner-addon that referenced this issue Feb 15, 2022
@skitt
Add InstallPlan configuration to SubmarinerConfig
8e02e00 
This adds an InstallPlanApproval entry to the SubscriptionConfig
object in SubmarinerConfig, allowing the subscription's
InstallPlanApproval entry to be configured.

Fixes: stolostron#270
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 4f1fafb)
@skitt skitt mentioned this issue Feb 15, 2022
Merged
openshift-merge-robot pushed a commit that referenced this issue Feb 15, 2022
@skitt @openshift-merge-robot
Add InstallPlan configuration to SubmarinerConfig
a6fee8f 
This adds an InstallPlanApproval entry to the SubscriptionConfig
object in SubmarinerConfig, allowing the subscription's
InstallPlanApproval entry to be configured.

Fixes: #270
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 4f1fafb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skitt skitt

Labels
None yet
Projects
Submariner ACM integration
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add InstallPlan configuration to SubmarinerConfig skitt/submariner-addon
4 participants
@skitt @nyechiel @manosnoam @MaxBab