Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InstallPlan configuration to SubmarinerConfig #284

Conversation

skitt
Copy link
Member

@skitt skitt commented Feb 15, 2022

This adds an InstallPlanApproval entry to the SubscriptionConfig
object in SubmarinerConfig, allowing the subscription's
InstallPlanApproval entry to be configured.

Fixes: #270
Signed-off-by: Stephen Kitt skitt@redhat.com
(cherry picked from commit 4f1fafb)

This adds an InstallPlanApproval entry to the SubscriptionConfig
object in SubmarinerConfig, allowing the subscription's
InstallPlanApproval entry to be configured.

Fixes: stolostron#270
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 4f1fafb)
@skitt
Copy link
Member Author

skitt commented Feb 15, 2022

/cc @sridhargaddam @tpantelis

@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sridhargaddam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sridhargaddam
Copy link
Contributor

/lgtm

@sridhargaddam sridhargaddam removed their assignment Feb 15, 2022
@openshift-merge-robot openshift-merge-robot merged commit a6fee8f into stolostron:release-2.4 Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants