From 0d92729b52cb081a21a0a65b503d39b0b17df60b Mon Sep 17 00:00:00 2001 From: Stanley Sathler Date: Fri, 26 Oct 2018 00:07:07 -0300 Subject: [PATCH 01/15] fix(button): button's content doesn't trigger click event when disabled Now, when an element inside a disabled button is clicked, the button's click event is not called anymore. Fixes issue #68. --- .../src/component/Button.js | 15 ++++++++++- .../src/component/Button.test.js | 26 +++++++++++++++++++ 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/packages/sling-web-component-button/src/component/Button.js b/packages/sling-web-component-button/src/component/Button.js index 44f9e387..ca020864 100644 --- a/packages/sling-web-component-button/src/component/Button.js +++ b/packages/sling-web-component-button/src/component/Button.js @@ -1,6 +1,11 @@ import { SlingElement, html } from 'sling-framework'; export class Button extends SlingElement { + constructor() { + super(); + this.handleClick = this.handleClick.bind(this); + } + static get properties() { return { layout: { @@ -30,6 +35,12 @@ export class Button extends SlingElement { }; } + handleClick(evt) { + if (this.disabled) { + evt.stopPropagation(); + } + } + render({ disabled, type }) { const base = 'emd-btn'; const attrNames = Object.keys(this.constructor.properties); @@ -40,7 +51,9 @@ export class Button extends SlingElement { @import url('sling-web-component-button/src/index.css'); `; } diff --git a/packages/sling-web-component-button/src/component/Button.test.js b/packages/sling-web-component-button/src/component/Button.test.js index c01e526d..a456e97a 100644 --- a/packages/sling-web-component-button/src/component/Button.test.js +++ b/packages/sling-web-component-button/src/component/Button.test.js @@ -1,3 +1,4 @@ +import sinon from 'sinon'; import { registerComponent } from 'sling-helpers'; import { Button } from './Button.js'; @@ -42,4 +43,29 @@ describe('Button', () => { done(); }); }); + + describe('Has "disabled" attribute', () => { + beforeEach(() => { + $button.disabled = true; + }); + + afterEach(() => { + $button.disabled = false; + }); + + it('Should not call "click" event handler when inner content ' + + 'is clicked.', (done) => { + const $innerContent = document.createElement('span'); + const clickSpy = sinon.spy(); + + $button.appendChild($innerContent); + $button.addEventListener('click', clickSpy); + $innerContent.click(); + + setTimeout(() => { + expect(clickSpy.called).to.equal(false); + done(); + }); + }); + }); }); From bd3ca65ae0dea372c2d7ffcd18bea84a4ae24aa8 Mon Sep 17 00:00:00 2001 From: Gabriel Lima Date: Sat, 27 Oct 2018 21:37:26 -0300 Subject: [PATCH 02/15] Add sling-assets dependency --- .../package-lock.json | 46 +++++++++++++++++++ .../package.json | 1 + 2 files changed, 47 insertions(+) create mode 100644 packages/sling-web-component-brand-icon/package-lock.json diff --git a/packages/sling-web-component-brand-icon/package-lock.json b/packages/sling-web-component-brand-icon/package-lock.json new file mode 100644 index 00000000..3b0a8907 --- /dev/null +++ b/packages/sling-web-component-brand-icon/package-lock.json @@ -0,0 +1,46 @@ +{ + "name": "sling-web-component-brand-icon", + "version": "1.8.0", + "lockfileVersion": 1, + "requires": true, + "dependencies": { + "sling-assets": { + "version": "1.1.0", + "resolved": "https://registry.npmjs.org/sling-assets/-/sling-assets-1.1.0.tgz", + "integrity": "sha512-Yl14cgwvpm3/NZ0ViMLWY+oPgEXLjlh7/a1Val34mxP+u8CTCVHQv5aOF8E3aaQZeSo6d3Cp3pkDzImEdZ4DDQ==" + }, + "sling-framework": { + "version": "1.9.0", + "requires": { + "sling-helpers": "^1.9.1" + }, + "dependencies": { + "sling-helpers": { + "version": "1.10.0", + "bundled": true, + "requires": { + "moment": "^2.22.2" + }, + "dependencies": { + "moment": { + "version": "2.22.2", + "bundled": true + } + } + } + } + }, + "sling-helpers": { + "version": "1.10.0", + "requires": { + "moment": "^2.22.2" + }, + "dependencies": { + "moment": { + "version": "2.22.2", + "bundled": true + } + } + } + } +} diff --git a/packages/sling-web-component-brand-icon/package.json b/packages/sling-web-component-brand-icon/package.json index c6f7216a..ff98705a 100644 --- a/packages/sling-web-component-brand-icon/package.json +++ b/packages/sling-web-component-brand-icon/package.json @@ -7,6 +7,7 @@ "jsnext:main": "dist/es/es6/index.js", "author": "Stone Pagamentos", "dependencies": { + "sling-assets": "^1.1.0", "sling-framework": "^1.8.0", "sling-helpers": "^1.8.0" } From 2a259f9797bb776383a31b7c61007bf45878c80a Mon Sep 17 00:00:00 2001 From: Gabriel Lima Date: Sat, 27 Oct 2018 21:38:03 -0300 Subject: [PATCH 03/15] Import visa svg asset from sling-assets --- .../src/component/BrandIcon.js | 20 +++---------------- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/packages/sling-web-component-brand-icon/src/component/BrandIcon.js b/packages/sling-web-component-brand-icon/src/component/BrandIcon.js index ab05918a..f2e17df6 100644 --- a/packages/sling-web-component-brand-icon/src/component/BrandIcon.js +++ b/packages/sling-web-component-brand-icon/src/component/BrandIcon.js @@ -1,3 +1,5 @@ +import { icons } from 'sling-assets'; + export class BrandIcon extends HTMLElement { constructor() { super(); @@ -60,23 +62,7 @@ export class BrandIcon extends HTMLElement { getSvg() { switch (this.brandid) { case 1: // visa - return ` - - - - - - - - - - - - - - - - `; + return icons.VISA; case 2: // mastercard return ` From ec455225251cc11453e711db76967d9419ce7b03 Mon Sep 17 00:00:00 2001 From: Gabriel Lima Date: Sat, 27 Oct 2018 21:40:06 -0300 Subject: [PATCH 04/15] Add VISA card brand asset --- .../sling-assets/src/icons/js/cardbrand-visa.js | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 packages/sling-assets/src/icons/js/cardbrand-visa.js diff --git a/packages/sling-assets/src/icons/js/cardbrand-visa.js b/packages/sling-assets/src/icons/js/cardbrand-visa.js new file mode 100644 index 00000000..507e2df9 --- /dev/null +++ b/packages/sling-assets/src/icons/js/cardbrand-visa.js @@ -0,0 +1,17 @@ +export const VISA = ` + + + + + + + + + + + + + + + +`; From e5d930674fbb0f0bb60d1cff1e8031c641e32a6c Mon Sep 17 00:00:00 2001 From: Gabriel Lima Date: Sat, 27 Oct 2018 21:47:31 -0300 Subject: [PATCH 05/15] Export VISA brand icon --- packages/sling-assets/src/icons/index.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/sling-assets/src/icons/index.js b/packages/sling-assets/src/icons/index.js index 369c05d0..1374a0c4 100644 --- a/packages/sling-assets/src/icons/index.js +++ b/packages/sling-assets/src/icons/index.js @@ -3,6 +3,7 @@ import { CHECK_CIRCLE } from './js/baseline-check_circle-24px.js'; import { CLOSE } from './js/baseline-close-24px.js'; import { ERROR } from './js/baseline-error-24px.js'; import { FEEDBACK } from './js/baseline-feedback-24px.js'; +import { VISA } from './js/cardbrand-visa.js'; export { CANCEL, @@ -10,4 +11,5 @@ export { CLOSE, ERROR, FEEDBACK, + VISA, }; From 7d063466d8d1087041c50187d30a75a4627265cb Mon Sep 17 00:00:00 2001 From: Gabriel Lima Date: Sat, 27 Oct 2018 22:27:36 -0300 Subject: [PATCH 06/15] Add all other brands --- packages/sling-assets/src/icons/index.js | 20 ++++++++++ .../src/icons/js/cardbrand-alelo.js | 35 +++++++++++++++++ .../icons/js/cardbrand-american-express.js | 34 ++++++++++++++++ .../src/icons/js/cardbrand-elo.js | 22 +++++++++++ .../src/icons/js/cardbrand-hipercard.js | 11 ++++++ .../src/icons/js/cardbrand-mastercard.js | 21 ++++++++++ .../src/icons/js/cardbrand-senff.js | 17 ++++++++ .../src/icons/js/cardbrand-sodexo.js | 21 ++++++++++ .../src/icons/js/cardbrand-stone.js | 39 +++++++++++++++++++ .../src/icons/js/cardbrand-ticket.js | 13 +++++++ .../sling-assets/src/icons/js/cardbrand-vr.js | 15 +++++++ 11 files changed, 248 insertions(+) create mode 100644 packages/sling-assets/src/icons/js/cardbrand-alelo.js create mode 100644 packages/sling-assets/src/icons/js/cardbrand-american-express.js create mode 100644 packages/sling-assets/src/icons/js/cardbrand-elo.js create mode 100644 packages/sling-assets/src/icons/js/cardbrand-hipercard.js create mode 100644 packages/sling-assets/src/icons/js/cardbrand-mastercard.js create mode 100644 packages/sling-assets/src/icons/js/cardbrand-senff.js create mode 100644 packages/sling-assets/src/icons/js/cardbrand-sodexo.js create mode 100644 packages/sling-assets/src/icons/js/cardbrand-stone.js create mode 100644 packages/sling-assets/src/icons/js/cardbrand-ticket.js create mode 100644 packages/sling-assets/src/icons/js/cardbrand-vr.js diff --git a/packages/sling-assets/src/icons/index.js b/packages/sling-assets/src/icons/index.js index 1374a0c4..68f00159 100644 --- a/packages/sling-assets/src/icons/index.js +++ b/packages/sling-assets/src/icons/index.js @@ -4,6 +4,16 @@ import { CLOSE } from './js/baseline-close-24px.js'; import { ERROR } from './js/baseline-error-24px.js'; import { FEEDBACK } from './js/baseline-feedback-24px.js'; import { VISA } from './js/cardbrand-visa.js'; +import { MASTERCARD } from './js/cardbrand-mastercard.js'; +import { AMERICAN_EXPRESS } from './js/cardbrand-american-express.js'; +import { TICKET } from './js/cardbrand-ticket.js'; +import { SODEXO } from './js/cardbrand-sodexo.js'; +import { VR } from './js/cardbrand-vr.js'; +import { ALELO } from './js/cardbrand-alelo.js'; +import { HIPERCARD } from './js/cardbrand-hipercard.js'; +import { SENFF } from './js/cardbrand-senff'; +import { ELO } from './js/cardbrand-elo'; +import { STONE } from './js/cardbrand-stone'; export { CANCEL, @@ -12,4 +22,14 @@ export { ERROR, FEEDBACK, VISA, + MASTERCARD, + AMERICAN_EXPRESS, + TICKET, + SODEXO, + VR, + ALELO, + HIPERCARD, + SENFF, + ELO, + STONE, }; diff --git a/packages/sling-assets/src/icons/js/cardbrand-alelo.js b/packages/sling-assets/src/icons/js/cardbrand-alelo.js new file mode 100644 index 00000000..cf544de8 --- /dev/null +++ b/packages/sling-assets/src/icons/js/cardbrand-alelo.js @@ -0,0 +1,35 @@ +export const ALELO = ` + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +`; \ No newline at end of file diff --git a/packages/sling-assets/src/icons/js/cardbrand-american-express.js b/packages/sling-assets/src/icons/js/cardbrand-american-express.js new file mode 100644 index 00000000..5a4bd962 --- /dev/null +++ b/packages/sling-assets/src/icons/js/cardbrand-american-express.js @@ -0,0 +1,34 @@ +export const AMERICAN_EXPRESS = +` + + + + + + +`; diff --git a/packages/sling-assets/src/icons/js/cardbrand-elo.js b/packages/sling-assets/src/icons/js/cardbrand-elo.js new file mode 100644 index 00000000..8b5efb9d --- /dev/null +++ b/packages/sling-assets/src/icons/js/cardbrand-elo.js @@ -0,0 +1,22 @@ +export const ELO = ` + + + + + + + + + + + + + + + + + + + + +`; diff --git a/packages/sling-assets/src/icons/js/cardbrand-hipercard.js b/packages/sling-assets/src/icons/js/cardbrand-hipercard.js new file mode 100644 index 00000000..05192293 --- /dev/null +++ b/packages/sling-assets/src/icons/js/cardbrand-hipercard.js @@ -0,0 +1,11 @@ +export const HIPERCARD = ` + + + + + + + +`; diff --git a/packages/sling-assets/src/icons/js/cardbrand-mastercard.js b/packages/sling-assets/src/icons/js/cardbrand-mastercard.js new file mode 100644 index 00000000..14207b0c --- /dev/null +++ b/packages/sling-assets/src/icons/js/cardbrand-mastercard.js @@ -0,0 +1,21 @@ +export const MASTERCARD = ` + + + + + + + + + + + + + + + + + + + +`; diff --git a/packages/sling-assets/src/icons/js/cardbrand-senff.js b/packages/sling-assets/src/icons/js/cardbrand-senff.js new file mode 100644 index 00000000..33612ab5 --- /dev/null +++ b/packages/sling-assets/src/icons/js/cardbrand-senff.js @@ -0,0 +1,17 @@ +export const SENFF = ` + + + + + + + + + + + + + + + +`; \ No newline at end of file diff --git a/packages/sling-assets/src/icons/js/cardbrand-sodexo.js b/packages/sling-assets/src/icons/js/cardbrand-sodexo.js new file mode 100644 index 00000000..837d83bf --- /dev/null +++ b/packages/sling-assets/src/icons/js/cardbrand-sodexo.js @@ -0,0 +1,21 @@ +export const SODEXO = +` + + + + + + + + + + + + + + + + + + +`; diff --git a/packages/sling-assets/src/icons/js/cardbrand-stone.js b/packages/sling-assets/src/icons/js/cardbrand-stone.js new file mode 100644 index 00000000..965df66b --- /dev/null +++ b/packages/sling-assets/src/icons/js/cardbrand-stone.js @@ -0,0 +1,39 @@ +export const STONE = ` + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +`; \ No newline at end of file diff --git a/packages/sling-assets/src/icons/js/cardbrand-ticket.js b/packages/sling-assets/src/icons/js/cardbrand-ticket.js new file mode 100644 index 00000000..7b392317 --- /dev/null +++ b/packages/sling-assets/src/icons/js/cardbrand-ticket.js @@ -0,0 +1,13 @@ +export const TICKET = +` + + + + + + + +`; diff --git a/packages/sling-assets/src/icons/js/cardbrand-vr.js b/packages/sling-assets/src/icons/js/cardbrand-vr.js new file mode 100644 index 00000000..7cc10fff --- /dev/null +++ b/packages/sling-assets/src/icons/js/cardbrand-vr.js @@ -0,0 +1,15 @@ +export const VR = +` + + + + + + + + + + + + +`; From 7a7d559a7f635e8f7607346bc408243b02c0a87e Mon Sep 17 00:00:00 2001 From: Gabriel Lima Date: Sat, 27 Oct 2018 22:28:32 -0300 Subject: [PATCH 07/15] Import all other brand icons --- .../src/component/BrandIcon.js | 241 +----------------- 1 file changed, 10 insertions(+), 231 deletions(-) diff --git a/packages/sling-web-component-brand-icon/src/component/BrandIcon.js b/packages/sling-web-component-brand-icon/src/component/BrandIcon.js index f2e17df6..7ca2db93 100644 --- a/packages/sling-web-component-brand-icon/src/component/BrandIcon.js +++ b/packages/sling-web-component-brand-icon/src/component/BrandIcon.js @@ -64,246 +64,25 @@ export class BrandIcon extends HTMLElement { case 1: // visa return icons.VISA; case 2: // mastercard - return ` - - - - - - - - - - - - - - - - - - - - `; + return icons.MASTERCARD; case 3: // americanexpress - return ` - - - - - - - - `; + return icons.AMERICAN_EXPRESS; case 5: // ticket - return ` - - - - - - - - - - `; + return icons.TICKET; case 6: // sodexo - return ` - - - - - - - - - - - - - - - - - - - - - `; + return icons.SODEXO; case 7: // VR - return ` - - - - - - - - - - - - - - - `; + return icons.VR; case 8: // alelo - return ` - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - `; + return icons.ALELO; case 9: // hipercard - return ` - - - - - - - - `; + return icons.HIPERCARD; case 12: // senff - return ` - - - - - - - - - - - - - - - - `; + return icons.SENFF; case 171: // elo - return ` - - - - - - - - - - - - - - - - - - - - - `; + return icons.ELO; default: // stone - return ` - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - `; + return icons.STONE; } } From 1e4e0b1b27f225c37a5f9a5634d82882968e284f Mon Sep 17 00:00:00 2001 From: Gabriel Lima Date: Sat, 27 Oct 2018 22:30:22 -0300 Subject: [PATCH 08/15] Remove unecessary comments --- .../src/component/BrandIcon.js | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/packages/sling-web-component-brand-icon/src/component/BrandIcon.js b/packages/sling-web-component-brand-icon/src/component/BrandIcon.js index 7ca2db93..a1c9621b 100644 --- a/packages/sling-web-component-brand-icon/src/component/BrandIcon.js +++ b/packages/sling-web-component-brand-icon/src/component/BrandIcon.js @@ -61,27 +61,27 @@ export class BrandIcon extends HTMLElement { getSvg() { switch (this.brandid) { - case 1: // visa + case 1: return icons.VISA; - case 2: // mastercard + case 2: return icons.MASTERCARD; - case 3: // americanexpress + case 3: return icons.AMERICAN_EXPRESS; - case 5: // ticket + case 5: return icons.TICKET; - case 6: // sodexo + case 6: return icons.SODEXO; - case 7: // VR + case 7: return icons.VR; - case 8: // alelo + case 8: return icons.ALELO; - case 9: // hipercard + case 9: return icons.HIPERCARD; - case 12: // senff + case 12: return icons.SENFF; - case 171: // elo + case 171: return icons.ELO; - default: // stone + default: return icons.STONE; } } From 30d43053c49dda538961a009cdb7fc6787d61258 Mon Sep 17 00:00:00 2001 From: Gabriel Lima Date: Sat, 27 Oct 2018 22:35:19 -0300 Subject: [PATCH 09/15] Add svg files --- .../src/icons/svg/cardbrand-alelo.svg | 33 +++++++++++++++++ .../icons/svg/cardbrand-american-express.svg | 32 ++++++++++++++++ .../src/icons/svg/cardbrand-elo.svg | 20 ++++++++++ .../src/icons/svg/cardbrand-hipercard.svg | 9 +++++ .../src/icons/svg/cardbrand-mastercard.svg | 19 ++++++++++ .../src/icons/svg/cardbrand-senff.svg | 15 ++++++++ .../src/icons/svg/cardbrand-sodexo.svg | 20 ++++++++++ .../src/icons/svg/cardbrand-stone.svg | 37 +++++++++++++++++++ .../src/icons/svg/cardbrand-ticket.svg | 12 ++++++ .../src/icons/svg/cardbrand-visa.svg | 15 ++++++++ .../src/icons/svg/cardbrand-vr.svg | 14 +++++++ 11 files changed, 226 insertions(+) create mode 100644 packages/sling-assets/src/icons/svg/cardbrand-alelo.svg create mode 100644 packages/sling-assets/src/icons/svg/cardbrand-american-express.svg create mode 100644 packages/sling-assets/src/icons/svg/cardbrand-elo.svg create mode 100644 packages/sling-assets/src/icons/svg/cardbrand-hipercard.svg create mode 100644 packages/sling-assets/src/icons/svg/cardbrand-mastercard.svg create mode 100644 packages/sling-assets/src/icons/svg/cardbrand-senff.svg create mode 100644 packages/sling-assets/src/icons/svg/cardbrand-sodexo.svg create mode 100644 packages/sling-assets/src/icons/svg/cardbrand-stone.svg create mode 100644 packages/sling-assets/src/icons/svg/cardbrand-ticket.svg create mode 100644 packages/sling-assets/src/icons/svg/cardbrand-visa.svg create mode 100644 packages/sling-assets/src/icons/svg/cardbrand-vr.svg diff --git a/packages/sling-assets/src/icons/svg/cardbrand-alelo.svg b/packages/sling-assets/src/icons/svg/cardbrand-alelo.svg new file mode 100644 index 00000000..62f0e19a --- /dev/null +++ b/packages/sling-assets/src/icons/svg/cardbrand-alelo.svg @@ -0,0 +1,33 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/packages/sling-assets/src/icons/svg/cardbrand-american-express.svg b/packages/sling-assets/src/icons/svg/cardbrand-american-express.svg new file mode 100644 index 00000000..881358f6 --- /dev/null +++ b/packages/sling-assets/src/icons/svg/cardbrand-american-express.svg @@ -0,0 +1,32 @@ + + + + + + + diff --git a/packages/sling-assets/src/icons/svg/cardbrand-elo.svg b/packages/sling-assets/src/icons/svg/cardbrand-elo.svg new file mode 100644 index 00000000..479527e6 --- /dev/null +++ b/packages/sling-assets/src/icons/svg/cardbrand-elo.svg @@ -0,0 +1,20 @@ + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/packages/sling-assets/src/icons/svg/cardbrand-hipercard.svg b/packages/sling-assets/src/icons/svg/cardbrand-hipercard.svg new file mode 100644 index 00000000..c1e28a00 --- /dev/null +++ b/packages/sling-assets/src/icons/svg/cardbrand-hipercard.svg @@ -0,0 +1,9 @@ + + + + + + + \ No newline at end of file diff --git a/packages/sling-assets/src/icons/svg/cardbrand-mastercard.svg b/packages/sling-assets/src/icons/svg/cardbrand-mastercard.svg new file mode 100644 index 00000000..14568ffe --- /dev/null +++ b/packages/sling-assets/src/icons/svg/cardbrand-mastercard.svg @@ -0,0 +1,19 @@ + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/packages/sling-assets/src/icons/svg/cardbrand-senff.svg b/packages/sling-assets/src/icons/svg/cardbrand-senff.svg new file mode 100644 index 00000000..bb9f1f52 --- /dev/null +++ b/packages/sling-assets/src/icons/svg/cardbrand-senff.svg @@ -0,0 +1,15 @@ + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/packages/sling-assets/src/icons/svg/cardbrand-sodexo.svg b/packages/sling-assets/src/icons/svg/cardbrand-sodexo.svg new file mode 100644 index 00000000..7b1c8c3d --- /dev/null +++ b/packages/sling-assets/src/icons/svg/cardbrand-sodexo.svg @@ -0,0 +1,20 @@ + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/packages/sling-assets/src/icons/svg/cardbrand-stone.svg b/packages/sling-assets/src/icons/svg/cardbrand-stone.svg new file mode 100644 index 00000000..2852d33d --- /dev/null +++ b/packages/sling-assets/src/icons/svg/cardbrand-stone.svg @@ -0,0 +1,37 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/packages/sling-assets/src/icons/svg/cardbrand-ticket.svg b/packages/sling-assets/src/icons/svg/cardbrand-ticket.svg new file mode 100644 index 00000000..b73599c5 --- /dev/null +++ b/packages/sling-assets/src/icons/svg/cardbrand-ticket.svg @@ -0,0 +1,12 @@ + + + + + + + + + \ No newline at end of file diff --git a/packages/sling-assets/src/icons/svg/cardbrand-visa.svg b/packages/sling-assets/src/icons/svg/cardbrand-visa.svg new file mode 100644 index 00000000..36986182 --- /dev/null +++ b/packages/sling-assets/src/icons/svg/cardbrand-visa.svg @@ -0,0 +1,15 @@ + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/packages/sling-assets/src/icons/svg/cardbrand-vr.svg b/packages/sling-assets/src/icons/svg/cardbrand-vr.svg new file mode 100644 index 00000000..5d9b0fdb --- /dev/null +++ b/packages/sling-assets/src/icons/svg/cardbrand-vr.svg @@ -0,0 +1,14 @@ + + + + + + + + + + + + + + \ No newline at end of file From bf6a88cd73e2cbf0d3555759772c33a126f9cb6d Mon Sep 17 00:00:00 2001 From: Gabriel Lima Date: Sat, 27 Oct 2018 22:43:48 -0300 Subject: [PATCH 10/15] Fix lint --- packages/sling-assets/src/icons/js/cardbrand-alelo.js | 2 +- packages/sling-assets/src/icons/js/cardbrand-senff.js | 2 +- packages/sling-assets/src/icons/js/cardbrand-stone.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/sling-assets/src/icons/js/cardbrand-alelo.js b/packages/sling-assets/src/icons/js/cardbrand-alelo.js index cf544de8..245b7fe5 100644 --- a/packages/sling-assets/src/icons/js/cardbrand-alelo.js +++ b/packages/sling-assets/src/icons/js/cardbrand-alelo.js @@ -32,4 +32,4 @@ export const ALELO = ` -`; \ No newline at end of file +`; diff --git a/packages/sling-assets/src/icons/js/cardbrand-senff.js b/packages/sling-assets/src/icons/js/cardbrand-senff.js index 33612ab5..4c54cc8e 100644 --- a/packages/sling-assets/src/icons/js/cardbrand-senff.js +++ b/packages/sling-assets/src/icons/js/cardbrand-senff.js @@ -14,4 +14,4 @@ export const SENFF = ` -`; \ No newline at end of file +`; diff --git a/packages/sling-assets/src/icons/js/cardbrand-stone.js b/packages/sling-assets/src/icons/js/cardbrand-stone.js index 965df66b..de6302fd 100644 --- a/packages/sling-assets/src/icons/js/cardbrand-stone.js +++ b/packages/sling-assets/src/icons/js/cardbrand-stone.js @@ -36,4 +36,4 @@ export const STONE = ` -`; \ No newline at end of file +`; From 85d284f8d7af4fcb58de9b78d7f537f4eea2fecb Mon Sep 17 00:00:00 2001 From: Gabriel Lima Date: Sun, 11 Nov 2018 17:48:34 -0200 Subject: [PATCH 11/15] feat: Use sling assets on sling-web-component-brand-icon From 188c5afc48e6ad92d7dff823b480ae05ca12908e Mon Sep 17 00:00:00 2001 From: Leonardo Favre | Stone Date: Tue, 13 Nov 2018 17:44:32 -0200 Subject: [PATCH 12/15] fix: Make American Express and Alelo logos appear on Safari --- packages/sling-assets/src/icons/js/cardbrand-alelo.js | 5 +---- .../src/icons/js/cardbrand-american-express.js | 8 ++------ packages/sling-assets/src/icons/svg/cardbrand-alelo.svg | 5 +---- .../src/icons/svg/cardbrand-american-express.svg | 8 ++------ packages/sling-assets/src/images/logo-alelo.svg | 5 +---- packages/sling-assets/src/images/logo-americanexpress.svg | 8 ++------ 6 files changed, 9 insertions(+), 30 deletions(-) diff --git a/packages/sling-assets/src/icons/js/cardbrand-alelo.js b/packages/sling-assets/src/icons/js/cardbrand-alelo.js index 245b7fe5..4c18969a 100644 --- a/packages/sling-assets/src/icons/js/cardbrand-alelo.js +++ b/packages/sling-assets/src/icons/js/cardbrand-alelo.js @@ -1,8 +1,5 @@ export const ALELO = ` - - - @@ -12,7 +9,7 @@ export const ALELO = ` - + diff --git a/packages/sling-assets/src/icons/js/cardbrand-american-express.js b/packages/sling-assets/src/icons/js/cardbrand-american-express.js index 5a4bd962..dc34f8df 100644 --- a/packages/sling-assets/src/icons/js/cardbrand-american-express.js +++ b/packages/sling-assets/src/icons/js/cardbrand-american-express.js @@ -1,16 +1,12 @@ export const AMERICAN_EXPRESS = ` - - - -