Make sure to ament_export_libraries. #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ament_export_libraries() ends up generating a setup.sh file for each library that exports LD_LIBRARY_PATH. This is important when building in isolated mode so that downstream consumers of the libraries can find the library at runtime. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
Seems a bit redundant to export the interfaces AND the libraries. Should ament be adding |
|
Will need a PR over in ecl_lite too. |
It's a good question, I don't know the answer. It's probably worth bringing up in |
Oops, yeah. I had to do fixes over there too, PR upcoming. |
This was referenced May 8, 2018
Closed
stonier
added a commit
that referenced
this pull request
Sep 27, 2018
As brought in, in PR 73 #73 Reported in ament/ament_cmake#132 And fixed in https://github.com/ament/ament_cmake/pull/135/files
stonier
added a commit
to stonier/ecl_lite
that referenced
this pull request
Sep 27, 2018
As brought in, in PR 73 stonier/ecl_core#73 Reported in ament/ament_cmake#132 And fixed in https://github.com/ament/ament_cmake/pull/135/files
This was referenced Sep 27, 2018
stonier
added a commit
that referenced
this pull request
Sep 27, 2018
* [infra] rever the workaround (PR #73) for interface library exports Hitherto would cause a problem on builds with isolated installs, so you are supposed to explicitly state the target name, refer to - ament/ament_cmake#132 - https://github.com/ament/ament_cmake/pull/135/files Colcon/bouncy doesn't reproduce our earlier problems since it exports all of the appropriate paths regardless. This however, should be the right fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ament_export_libraries() ends up generating a setup.sh file
for each library that exports LD_LIBRARY_PATH. This is
important when building in isolated mode so that downstream
consumers of the libraries can find the library at runtime.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org