New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and move security validations #804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6124d1b
to
12538e9
Compare
12538e9
to
2c7c704
Compare
d3c99f5
to
08793ce
Compare
d4d731f
to
f689fd3
Compare
f689fd3
to
b9d4e42
Compare
karol-maciaszek
suggested changes
Nov 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, yet another piece of code is polished 👍
Couple minor comments added.
packages/http/src/validator/validators/security/handlers/index.ts
Outdated
Show resolved
Hide resolved
packages/http/src/validator/validators/security/handlers/index.ts
Outdated
Show resolved
Hide resolved
packages/http/src/validator/validators/security/handlers/index.ts
Outdated
Show resolved
Hide resolved
packages/http/src/validator/validators/security/handlers/utils.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: Karol Maciaszek <karol@maciaszek.pl>
karol-maciaszek
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will address most of the technical debt we had in the security validations. In particular:
unknownand weirdlodash.getcalls and use precise typesValidatorFnshape we're using forvaldidateInputandvalidateOutputThere are some other internal refactors that need to be done (although not urgent) because the current code is really hard to reason about. I'll tame this beast in the next airplane (tomorrow)