refactor: make security validations easier to reason about #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVincentX
force-pushed
the
feat/security-refactor
branch
from
a37d969
to
e320016
Compare
XVincentX
force-pushed
the
feat/security-refactor
branch
2 times, most recently
from
ebeb4a8
to
c404d6c
Compare
XVincentX
force-pushed
the
feat/security-refactor
branch
from
bae6c6b
to
7499c9e
Compare
XVincentX
force-pushed
the
feat/security-refactor
branch
from
35ac5ce
to
bdc0671
Compare
philsturgeon
approved these changes
Nov 20, 2019
XVincentX
force-pushed
the
feat/security-refactor
branch
from
1a41328
to
bd98e9a
Compare
XVincentX
force-pushed
the
feat/security-refactor
branch
from
de9ee1d
to
9c91343
Compare
Co-Authored-By: Karol Maciaszek <karol@maciaszek.pl>
XVincentX
force-pushed
the
feat/security-refactor
branch
from
6440f16
to
05a8928
Compare
karol-maciaszek
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR brings some significant simplification to the security checks that were made in Prism.
It literally took me ages to understand what was going on and why some choices were made so far — I guess this part definitely went out of control.
Hopefully this PR, although not 100% complete (but honestly I'm so tired of working on this section) will bring some clarity and order so that in the next flight refactor it one more time will be easier.