Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(reader): try to reduce flakiness under Windows #1239

Merged
merged 1 commit into from Jun 20, 2020

Conversation

P0lip
Copy link
Member

@P0lip P0lip commented Jun 18, 2020

Whether it helps or not - we shall see, but I hope so.

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

@P0lip P0lip added the chore label Jun 18, 2020
@P0lip P0lip self-assigned this Jun 18, 2020
@P0lip P0lip requested a review from nulltoken June 19, 2020 00:19
@P0lip P0lip marked this pull request as ready for review June 19, 2020 00:19
@@ -30,7 +30,7 @@ end
});

it('throws when fd cannot be accessed', () => {
return expect(readFile(2, { encoding: 'utf8' })).rejects.toThrow();
return expect(readFile(2147483647, { encoding: 'utf8' })).rejects.toThrow();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the highest valid number.

@nulltoken nulltoken merged commit e029e17 into develop Jun 20, 2020
@nulltoken nulltoken deleted the chore/test-flakiness branch June 20, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants