New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): correctly handle special characters in JUnit failure details #2028
Conversation
packages/cli/src/formatters/__tests__/__fixtures__/oas3-schema-errors.json
Outdated
Show resolved
Hide resolved
44da16a
to
43e1e52
Compare
Those details are contained in XML CDATA section and should therefore not be XML-escaped.
43e1e52
to
ffc1c1e
Compare
Harness tests adapted in 6807c2d π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
8ea6084
to
0039aea
Compare
@fgreinacher we have a daily release cronjob that runs at around 2pm CET, so your changes should be released within a few hours. |
Awesome, thanks @P0lip. I was a bit confused because there has not been a GitHub release for a long time. But I guess you just don't create releases anymore after switching to a monorepo setup, so all good! |
There'll be comments posted on your issues once the code is out. |
# [@stoplight/spectral-cli-v6.1.1](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-cli-v6.1.0...@stoplight/spectral-cli-v6.1.1) (2022-01-21) ### Bug Fixes * **cli:** add path to JUnit testcase name ([#2029](#2029)) ([062ae0c](062ae0c)) * **cli:** correctly handle special characters in JUnit failure details ([#2028](#2028)) ([cabd2a9](cabd2a9))
π This PR is included in version @stoplight/spectral-cli-v6.1.1 π The release is available on npm package (@latest dist-tag) Your semantic-release bot π¦π |
Those details are contained in XML CDATA section and should therefore not be XML-escaped.
Fixes #2027
Checklist
Does this PR introduce a breaking change?
π with β€ at Siemens