Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Deleted project not removed from recent projects list #66

Closed
rossmcdonald opened this issue Aug 23, 2019 · 4 comments

Comments

@rossmcdonald
Copy link
Contributor

commented Aug 23, 2019

Describe the bug

When removing project from settings menu, project is not removed from recent projects listing on Studio landing screen.

To Reproduce

  1. Within an open project in Studio web, go to Settings > Project Settings > Delete Project

Expected behavior

Project would be removed from project listing.

Additional Context

Please also verify that in studio desktop removing a project works as expected (with and without remove files option).

@rossmcdonald rossmcdonald added the bug label Aug 23, 2019

@marbemac marbemac added this to the Aug '19 Hardening milestone Aug 25, 2019

@chris-miaskowski chris-miaskowski self-assigned this Aug 29, 2019

@chris-miaskowski

This comment has been minimized.

Copy link

commented Aug 29, 2019

@rossmcdonald , @chohmann

I have dug into the code and discovered that in latest version deleting projects was disabled.

https://github.com/stoplightio/studio-internal/blob/329c71ca1c243035b40289de1e99644cd9b85357/src/components/SettingsDialog/ProjectPanel.tsx#L69

{process.env.RUN_CONTEXT === 'desktop' && (
        <FormGroup
          labelFor="delete-project-button"
          intent={Intent.DANGER}
          helperText="Removes the current project and optionally remove the associated file directory."
        >
          <Button
            id="delete-project-button"
            icon="trash"
            intent={Intent.DANGER}
            text="Delete Project"
            onClick={onDeleteProjectBtnClick}
          />
          <RemoveProjectDialog isOpen={isRemoveProjectDialogOpen} onClose={onProjectDeletionModalClose} />
        </FormGroup>
      )}

Is that related to the recent project settings changes? It this bug still relevant?

CC: @casserni @StefanDywersant @marbemac

@chohmann

This comment has been minimized.

Copy link

commented Aug 29, 2019

@rossmcdonald @chris-miaskowski In production right now, the Settings cog displayed in the bar is coming from Studio (so not the new project settings that I implemented). I can't speak for if those settings should actually delete the project from the Studio cache, removing it from your recent projects.

Th new project settings have been deployed to integration. I just confirmed again, that when using the Delete project from the new project settings, the project is successfully getting removed from the studio cache, removing it from your recent projects.

As part of the new project settings, I moved the Studio settings to the metabar (bottom bar), and hid the Delete Project button in these setting is web context, since the new project settings also has a delete project option.

image

image

image

This could still be an issue when using desktop mode, since the original studio settings delete project is still used in desktop context, and it might not be deleting the project from studio's cache. So I would test in desktop mode, and if it doesn't happen there, then this can be closed.

Here's the issue for project settings for reference: https://app.zenhub.com/workspaces/stoplight-5d3e2aef8de2f20001278712/issues/stoplightio/app-gen3/256

@wmhilton

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

It is not happening in Desktop. (Admittedly, some OTHER bug is happening on Desktop on my machine... but it is deleted from the recent projects list.) So this can probably be closed.

@chris-miaskowski

This comment has been minimized.

Copy link

commented Aug 30, 2019

Thank you for the write up @chohmann! I also wasn't able to reproduce in desktop app. Closing as "cannot reproduce".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.