Fix ValueError when trying to set both upper and lower size limits #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the installer_mode argument in PR storaged-project#212 by accident.
When changing size limits in the add dialog from something like (1 MiB, 2 MiB) to (256 MiB, 1 GiB) blivet-gui crashes because we try to change the lower limit to value greater than the upper limit which normally doesn't make sense when changing only one of the limits but is valid when changing both. This change adds a new function to change both limits with one call that makes sure the limits are changed in the correct order. Resolves: rhbz#1881472
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.