Stratis support #277
Draft
Stratis support #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtrefny
force-pushed
the
master_stratis-support
branch
from
c18c172
to
252f14b
Compare
vojtechtrefny
force-pushed
the
master_stratis-support
branch
from
252f14b
to
ebed86d
Compare
|
Hello @vojtechtrefny! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-04-18 14:30:57 UTC |
vojtechtrefny
force-pushed
the
master_stratis-support
branch
from
ebed86d
to
186c63f
Compare
vojtechtrefny
force-pushed
the
master_stratis-support
branch
from
186c63f
to
a4a8e8f
Compare
Currently the max size is limited by the sum of parent devices sizes. Stratis filesystems are first devices where we support overprovisioning (Stratis filesystem is always 1 TiB) so we need a special exception for them.
vojtechtrefny
force-pushed
the
master_stratis-support
branch
from
a4a8e8f
to
88c44f1
Compare
vojtechtrefny
force-pushed
the
master_stratis-support
branch
from
88c44f1
to
b027a3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason behind this is to test the blivet support for Stratis which needs to be merged first storaged-project/blivet#915 but this is working (with right versions of blivet and stratisd) and was surprisingly simple to implement.