Do not crash when a disk populator doesn't return kwargs #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens when trying to use Blivet on a system with a BIOS RAID without dmraid installed. Because we don't fully support BIOS RAIDs using MD the MDBiosRaidDevicePopulator helper fails to get kwargs for the BIOS RAID "disk" and populate fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens when trying to use Blivet on a system with a BIOS
RAID without dmraid installed. Because we don't fully support
BIOS RAIDs using MD the MDBiosRaidDevicePopulator helper fails
to get kwargs for the BIOS RAID "disk" and populate fails.
This is just a workaround. We should aim to fully support DDF RAIDs with MD (some changes will be needed in libblockdev too see storaged-project/libblockdev#722). Populator is also one the things we should focus when making Blivet more stable, returning
Nonefrom_get_kwargsmeans we try to pass**Nonefor the device constructor which crashes without even telling the user what's wrong.