Shallow copy another alignment property (#1408282) #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several blivet classes use custom __deepcopy__ methods to avoid deep copying some parted objects which we know can't be deep copied. Unfortunately the list of attributes excepted from deep copying for `DiskLabel` was missing one parted Alignment object, and with Python 3.6, we blow up trying to deepcopy that. This fixes the problem by adding that attribute to the list of ones we know have to be shallow copied.
|
FWIW I think 93c805d initially introduced this problem, because it changed the set of alignment attributes that |
|
Jenkins, ok to test. |
dwlehman
approved these changes
Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several blivet classes use custom deepcopy methods to avoid
deep copying some parted objects which we know can't be deep
copied. Unfortunately the list of attributes excepted from deep
copying for
DiskLabelwas missing one parted Alignment object,and with Python 3.6, we blow up trying to deepcopy that. This
fixes the problem by adding that attribute to the list of ones
we know have to be shallow copied.