udisks-2.1.8 ports #149
Merged
udisks-2.1.8 ports #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.freedesktop.org/show_bug.cgi?id=95394 Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
https://bugs.freedesktop.org/show_bug.cgi?id=96816 Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
https://bugs.freedesktop.org/show_bug.cgi?id=97592 Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
When the udev device is not initialized it may not contain all of its properties yet, which makes udisks provide an incorrect representation of the to its clients. This is particularly problematic during the system initialization phase, where udev is also in it coldplug phase. udev will send an event when each device becomes initialized, so we can safely skip it during coldplug and rely on hotplug even handling instead. https://bugs.freedesktop.org/show_bug.cgi?id=96832 Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
The parent mount point dir (/run/media/user) already controls access permissions, so there is no need to set umask to 077 for exfat either. This makes UDISKS_FILESYSTEM_SHARED="1" actually work for exfat. Similar to commit ffcb11b1 for vfat and ntfs. https://bugs.freedesktop.org/show_bug.cgi?id=97348 Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
Linux C libraries are moving away from implicit includes of sys/sysmacros.h, so pull in this header directly in the files that use these funcs. https://bugs.freedesktop.org/show_bug.cgi?id=95028 Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
In the common case when we got a DBusException we previously skipped the time.sleep() and thus were just racing through the retry loop without actually giving the child process any time to start up. Also raise a proper exception on timeout instead of os.abort(). The latter did not flush stderr fast enough to actually see the failure message, and as this happens in the parent pid we actually can raise an exception meaningfully. LP: #1585382 Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
GMainLoop already handles SIGTERM, but we have our own signal handler for SIGINT, so use that. https://bugs.freedesktop.org/show_bug.cgi?id=97349 Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
vojtechtrefny
approved these changes
Dec 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are ports of the fixes/improvements included in the udisks-2.1.8 release [1].
[1] https://lists.freedesktop.org/archives/devkit-devel/2016-November/001763.html