Skip to content

Added NextScript component #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2020
Merged

Added NextScript component #101

merged 4 commits into from
Jun 9, 2020

Conversation

@markbrocato
Copy link
Contributor

@markbrocato markbrocato commented Jun 9, 2020 •
edited
Loading

React Storefront's NextScript component gives developers greater control over how script elements are rendered.

Example:

import NextScript from 'react-storefront/NextScript'

<NextScript mode="defer"/>

@markbrocato
Added NextScriptDeferred component that allows you to import scripts …
9e538e8 
…with defer instead of async in _document.js.
@markbrocato markbrocato requested a review from tonylepmets June 9, 2020 08:43
@markbrocato markbrocato changed the title Added NextScriptDeferred component that allows you to import scripts … Added NextScript component that allows you to import scripts … Jun 9, 2020
@markbrocato markbrocato changed the title Added NextScript component that allows you to import scripts … Added NextScript component Jun 9, 2020
@markbrocato markbrocato merged commit d3624bc into master Jun 9, 2020
@markbrocato markbrocato deleted the defer-scripts branch June 9, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tonylepmets tonylepmets tonylepmets approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markbrocato @tonylepmets