Skip to content

Making sure AMP optimizer is bundled #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Making sure AMP optimizer is bundled #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/plugins/withReactStorefront.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,15 @@ module.exports = ({ prefetchQueryParam, ...nextConfig } = {}) => {
}),
)

if (config.externals) {
// Making sure the AMP optimizer is bundled
config.externals = config.externals.filter(name => name !== '@ampproject/toolbox-optimizer')
// These are optional dependencies for the optimizer
// which are not used by default
config.externals.push('jimp')
config.externals.push('probe-image-size')
}

if (process.env.NODE_ENV === 'development') {
// This makes it easier to develop apps against a local clone of react-storefront linked with yalc. Here
// we ensure that the server build recompiles when any linked dependency changes.
Expand Down