Skip to content

Commit

Permalink
web/satellite: remove unnecessary session inactivity timer setup
Browse files Browse the repository at this point in the history
The dashboard area component would set up the session inactivity timers
after it was unmounted, conflicting with those that were started by
dashboards mounted afterward.

This issue caused session refresh requests to be sent more often than
they should have been. Additionally, expiration of the old set of
timers would clear newer ones before they were due to expire.

Change-Id: I86a73f13dab4cd8f979181b29002eb3b3e6e8bac
  • Loading branch information
jewharton committed Apr 24, 2023
1 parent 1aa24b9 commit 8056132
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
4 changes: 0 additions & 4 deletions web/satellite/src/views/DashboardArea.vue
Expand Up @@ -687,10 +687,6 @@ onMounted(async () => {
await usersStore.getSettings();
setupSessionTimers();
} catch (error) {
usersStore.$onAction((action) => {
if (action.name === 'login') setupSessionTimers();
});
if (!(error instanceof ErrorUnauthorized)) {
appStore.changeState(FetchState.ERROR);
await notify.error(error.message, AnalyticsErrorEventSource.OVERALL_APP_WRAPPER_ERROR);
Expand Down
4 changes: 0 additions & 4 deletions web/satellite/src/views/all-dashboard/AllDashboardArea.vue
Expand Up @@ -567,10 +567,6 @@ onMounted(async () => {
await usersStore.getSettings();
setupSessionTimers();
} catch (error) {
usersStore.$onAction((action) => {
if (action.name === 'login') setupSessionTimers();
});
if (!(error instanceof ErrorUnauthorized)) {
appStore.changeState(FetchState.ERROR);
await notify.error(error.message, AnalyticsErrorEventSource.ALL_PROJECT_DASHBOARD);
Expand Down

0 comments on commit 8056132

Please sign in to comment.