Installing a pinned release of Sphinx. #1175
Conversation
This will help us avoid issues with docs search across SDKs in the future.
There was a problem hiding this comment.
Hey @rdegges. Additional comment, please target 1.2.x or 1.3.x but not master (this comment is for current status of the repository, in the future master will be a target branch again). There is a chance that 1.3.x will be released sooner than 1.2.x. Up to you to decide which is the proper branch for this PR.
Thanks for taking care of this! Back to you
ci/install.sh
Outdated
|
|
||
| info "Installing Sphinx..." | ||
| pip -q install --user sphinx &> $WORKDIR/target/pip.log | ||
| pip -q install -r requirements.txt &> $WORKDIR/target/pip.log |
There was a problem hiding this comment.
Since this requirements file is only for docs, can you please move it from root and place it inside the docs dir? You could also put it inside ci (where the install.sh file exists).
There was a problem hiding this comment.
I asume --user sphinx is not needed for any reason, please confirm. I just want to be sure why it was removed.
There was a problem hiding this comment.
Correct: --user sphinx is now deprecated with the new Travis stuff =)
|
@mrioan just updated the file location. Let me know if this works for ya! |
mraible
dismissed
mrioan’s stale review
Randall has satisfied Mario's requests
This will help us avoid issues with docs search across SDKs in the future.
NOTE: Please don't merge this yet, please review.