Fix forwarding of actions handlers #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j3rem1e
added
bug
benmccann
reviewed
Sep 18, 2023
README.md
Outdated
| @@ -33,7 +33,9 @@ It supports: | |||
| </script> | |||
|
|
|||
| <Template let:args> | |||
| <Button {...args} on:click={handleClick}> | |||
| <Button {...args} | |||
| on:click <-- forwarded for actions | |||
There was a problem hiding this comment.
<-- is pretty close to <!-- which I read it as first. it might be nice to actually make it a comment like that and expand the text a bit
There was a problem hiding this comment.
It was just a way to put a comment near the attribute, but yeah, I'll rewrite that ^^
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107