-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More maintainers needed #11
Comments
Not sure if I could commit to maintaining, but definitely interested in contributing! |
I might chime in soon as well. |
Happy to try and help -- I saw recent storybook post saying pluggable builders are coming but nothing official. Our team are vite + tailwind JIT + vue3 and the WebPack/storybook misalignment causes headaches |
@17twenty That's great! If you run across any problems, you can open PRs here! Just send me a message if you're stuck with setting up the dev environment. |
I'd love to help developing this in free time. I have little experience in bundlers space so it'd be great if you could give me some tips and resources to read |
What you should do is join the Vite (https://chat.vitejs.dev/) and Storybook (https://storybook.js.org/community) spaces in Discord. In Vite land, there are some channels, like For this repo, run a git clone, yarn install, and you should be good to go! You can tweak the example project (or create another example project for Vue or whatever), and they should run with the local Storybook builder. |
@17twenty have you been able to get storybook-builder-vite working with vue3? Have you hit any snags? |
@eirslett Don't know much about storybook, but willing to contribute by looking into issues regarding vite. Thanks |
@soulsam480 That's great! The most valuable contribution at this time is probably people who use Vite for their production Storybook, and finding bugs that happen in more complex scenarios. And then send bug fixes! |
Are there any plans to rewrite things in typescript? |
Not right now. We could, but (in my opinion) it's easier to use JavaScript in the backend/with Node.js because we don't need transpilation or ts-node, and debugging/breakpoints is more ergonomic. If TypeScript gives us a lot of value, we could use |
Typescript is not only about types, it's also about features that are not yet added in JS and the possibility to target specific versions of JS during transpile. Now will those things bring value to the project, it's up to you ;) |
Last time I tried stepping through/debugging TypeScript code was 3 months ago. I was writing this plugin and tried to figure out what was happening internally inside Storybook (which is written in TypeScript). I ran the server code via IntelliJ, and for me it was a painful experience. Which is why this project uses JavaScript. But I'm sure we could switch to TypeScript if somebody writes a good documentation about how to set up a good/ergonomical development environment for storybook-builder-vite! I use TypeScript in my daily frontend work in the browser, I love the language, but like mentioned, I had problems with it in backend code. |
Happy to help on some of it if needed, I however don't have a major level of experience with vite. I will however try and help with some of the issues. |
I'm also happy to lend a hand :) |
I'm happy to help :) I've had a lot of fun digging into vite and storybook. |
I'm happy to help 👯 |
Thanks! I think the best thing that people can do right now is to test out the builder in their own projects, looking for problems or rough edges. Aside from that, we have a few issues in the tracker that could use some investigation and troubleshooting, and we'd love any help you can give there. We're on the storybook discord in the #vite channel throughout different parts of the day, so feel free to pop in and chat there, as well! |
Happy to help solve any issues. We about to integrate core plugin this into nxext . So happy to help make this great |
I will be glad to help to simplify the development process, more information in #188. |
Hey! I would like to help! :) |
This project needs more maintainers. Are you willing to contribute? Please reply on this issue, or send me a message directly.
The text was updated successfully, but these errors were encountered: