-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .storybook
to server.fs.allow
#427
Conversation
Thanks for the PR. Do you know why this might be necessary? With my understanding of the |
I think the docs are wrong. As soon as you specify one directory in the allow list it no longer allows the workspace root: SvelteKit adds directories to the allow list by default, so I think the workspace root would not get added: |
Oh I see, thanks. In that case, I'm reluctant to merge this change, as it would have the same impact for everyone else not using sveltekit who might need files in other directories within the workspace root. I don't suppose the sveltekit vite plugin could re-add the workspace root, so as to restore the default behavior? |
Good point. I've updated this with a new solution that will still work if the user hasn't defined |
Thanks for the contribution! |
Closes #426