Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove + from contributors #125

Merged
merged 2 commits into from
Aug 3, 2020
Merged

Remove + from contributors #125

merged 2 commits into from
Aug 3, 2020

Conversation

samrobbins85
Copy link
Contributor

This lists the total number of contributors, so it makes more sense without the plus

@netlify
Copy link

netlify bot commented Aug 3, 2020

Deploy request for storybook-frontpage rejected.

Rejected with commit 4f74fad

https://docs.netlify.com/configure-builds/environment-variables/#sensitive-variable-policy

@domyen
Copy link
Member

domyen commented Aug 3, 2020

Thanks for the contribution @samrobbins85. The plus is there to indicate that the contributor count is greater than 1035. So we still want it there.

However it's good that you submitted this PR because you called to attention that the + character is in the wrong place. Instead of +1035 it should read 1035+.

Is that something you'd be interested in updating in this PR? This pattern is also present in another location on the TeamScreen.

@samrobbins85
Copy link
Contributor Author

Fixed the homepage, but on the team page it seems to be the correct pattern as it shows that there are 1030 developers in addition to the ones shown

@domyen
Copy link
Member

domyen commented Aug 3, 2020

Nice! Thank you.

@domyen domyen merged commit 86dea0c into storybookjs:master Aug 3, 2020
@samrobbins85 samrobbins85 deleted the patch-1 branch August 5, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants