From 597827d97eb2cb890593ba6bd105a6075440a337 Mon Sep 17 00:00:00 2001 From: Simon Knox Date: Sun, 9 Jul 2017 23:49:03 +1000 Subject: [PATCH] key and value for select knob match key/value of options fixes #799 --- addons/knobs/src/components/types/Select.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/addons/knobs/src/components/types/Select.js b/addons/knobs/src/components/types/Select.js index 1777dce1603b..a4c6ce2daae4 100644 --- a/addons/knobs/src/components/types/Select.js +++ b/addons/knobs/src/components/types/Select.js @@ -18,18 +18,19 @@ const styles = { }; class SelectType extends React.Component { - _makeOpt(key, val) { + _makeOpt(key, value) { const opts = { key, - value: key, + value, }; return ( ); } + _options(values) { let data = []; if (Array.isArray(values)) { @@ -68,6 +69,7 @@ SelectType.propTypes = { knob: PropTypes.shape({ name: PropTypes.string, value: PropTypes.string, + options: PropTypes.oneOfType([PropTypes.array, PropTypes.object]), }), onChange: PropTypes.func, };