From 90353e770c160cf1bfbc4656d9b4d928c7156b66 Mon Sep 17 00:00:00 2001 From: Ian VanSchooten Date: Fri, 28 Oct 2022 08:46:48 -0400 Subject: [PATCH 1/3] Make ESLint the default formatter in vscode --- .vscode/settings.json | 18 +++++++++++++++++- code/.vscode/settings.json | 18 +++++++++++++++++- 2 files changed, 34 insertions(+), 2 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index e4831db738b6..9575451f2d96 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -1,4 +1,20 @@ { "deepscan.enable": true, - "typescript.tsdk": "./code/node_modules/typescript/lib" + "typescript.tsdk": "./code/node_modules/typescript/lib", + "[javascript]": { + "editor.defaultFormatter": "dbaeumer.vscode-eslint", + "editor.formatOnSave": true + }, + "[javascriptreact]": { + "editor.defaultFormatter": "dbaeumer.vscode-eslint", + "editor.formatOnSave": true + }, + "[typescript]": { + "editor.defaultFormatter": "dbaeumer.vscode-eslint", + "editor.formatOnSave": true + }, + "[typescriptreact]": { + "editor.defaultFormatter": "dbaeumer.vscode-eslint", + "editor.formatOnSave": true + }, } diff --git a/code/.vscode/settings.json b/code/.vscode/settings.json index 25fa6215fdd3..0bd6833d723b 100644 --- a/code/.vscode/settings.json +++ b/code/.vscode/settings.json @@ -1,3 +1,19 @@ { - "typescript.tsdk": "node_modules/typescript/lib" + "typescript.tsdk": "node_modules/typescript/lib", + "[javascript]": { + "editor.defaultFormatter": "dbaeumer.vscode-eslint", + "editor.formatOnSave": true + }, + "[javascriptreact]": { + "editor.defaultFormatter": "dbaeumer.vscode-eslint", + "editor.formatOnSave": true + }, + "[typescript]": { + "editor.defaultFormatter": "dbaeumer.vscode-eslint", + "editor.formatOnSave": true + }, + "[typescriptreact]": { + "editor.defaultFormatter": "dbaeumer.vscode-eslint", + "editor.formatOnSave": true + } } From 1289acd4a23250981f86bcac6e1eb608ab8873c9 Mon Sep 17 00:00:00 2001 From: Ian VanSchooten Date: Fri, 28 Oct 2022 08:47:25 -0400 Subject: [PATCH 2/3] Enable deepscan when working from /code --- code/.vscode/settings.json | 1 + 1 file changed, 1 insertion(+) diff --git a/code/.vscode/settings.json b/code/.vscode/settings.json index 0bd6833d723b..bfb6c11e6152 100644 --- a/code/.vscode/settings.json +++ b/code/.vscode/settings.json @@ -1,4 +1,5 @@ { + "deepscan.enable": true, "typescript.tsdk": "node_modules/typescript/lib", "[javascript]": { "editor.defaultFormatter": "dbaeumer.vscode-eslint", From 81d179230bacce2c80b1f4339d3405f4367187cb Mon Sep 17 00:00:00 2001 From: Ian VanSchooten Date: Wed, 2 Nov 2022 10:44:02 -0400 Subject: [PATCH 3/3] Configure eslint working directories for vscode --- .vscode/settings.json | 1 + code/.vscode/settings.json | 1 + 2 files changed, 2 insertions(+) diff --git a/.vscode/settings.json b/.vscode/settings.json index 9575451f2d96..75ad91c657f1 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -1,5 +1,6 @@ { "deepscan.enable": true, + "eslint.workingDirectories": ["./code", "./scripts"], "typescript.tsdk": "./code/node_modules/typescript/lib", "[javascript]": { "editor.defaultFormatter": "dbaeumer.vscode-eslint", diff --git a/code/.vscode/settings.json b/code/.vscode/settings.json index bfb6c11e6152..2a8b89c7e53a 100644 --- a/code/.vscode/settings.json +++ b/code/.vscode/settings.json @@ -1,5 +1,6 @@ { "deepscan.enable": true, + "eslint.workingDirectories": [".", "../scripts"], "typescript.tsdk": "node_modules/typescript/lib", "[javascript]": { "editor.defaultFormatter": "dbaeumer.vscode-eslint",